Webhook for Traccar by escoand · Pull Request #24762 · home-assistant/core

escoand · 2019-06-25T17:22:58Z

Breaking Change:

Nothing.

Description:

I've created a webhook integration for the Traccar Mobile Client. The same protocol is used by Osmand. Traccar is the simplest GPS tracker on the market and Osmand is one of the most advanced open source navigation apps for Android.

Related issue (if applicable): #24772

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10090

Example entry for `configuration.yaml` (if applicable):

none

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
Untested files have been added to .coveragerc.

If the code does not interact with devices:

Tests have been added to verify that the new code works.

ghost · 2019-06-25T17:23:06Z

Hey there @ludeeus, mind taking a look at this pull request as its been labeled with a integration (traccar) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

homeassistant/components/traccar/.translations/it.json

balloob · 2019-06-26T23:19:11Z

Traccar uses POST for their webhook if you set forward.json to true

https://github.com/traccar/traccar/blob/master/src/main/java/org/traccar/WebDataHandler.java#L179
https://www.traccar.org/configuration-file/

escoand · 2019-06-27T07:49:39Z

Thanks, but I'm focused on the Mobile Traccar Client. Especially the Android one.

escoand · 2019-07-16T11:06:49Z

@balloob I stumbled over #17782 and #19648 - is there any simple to use component (similar to webhook) planned for HTTP GET requests?

balloob · 2019-07-16T21:41:35Z

Since Traccar is open source, I suggest you contribute support for POST requests.

escoand · 2019-07-17T09:53:47Z

OK, I'll create an issue for Traccar. But this doesn't answer my question.

escoand · 2019-07-18T21:56:36Z

@balloob I've looked into the traccar code once more and realized they use POST request but the values as URL parameters. Is this working with the webhook component?

escoand · 2019-07-18T22:02:53Z

Obviously yes. I've implemented and tested it with wget in this way. Just saw the URL parameters in the code and concluded at GET request without verifying it.

So I have to verify Osmand as well.

MartinHjelmare · 2019-08-08T11:16:55Z

@escoand are you planning to finish here?

tests/components/traccar/test_init.py

escoand · 2019-08-08T19:05:49Z

@MartinHjelmare For me the integration seem production ready. Only the tests are failing because of my comment above. Can you help me here?

frenck · 2019-08-08T19:33:54Z

@escoand Format the code using Black, that should make it pass.

homeassistant/components/traccar/__init__.py

homeassistant/components/traccar/device_tracker.py

tests/components/traccar/test_init.py

Co-Authored-By: Martin Hjelmare <marhje52@kth.se>

MartinHjelmare

Looks good!

balloob · 2019-08-20T15:44:21Z

This PR forgot to add translations for the config flow.

balloob · 2019-08-20T15:53:41Z

Added in #26089

escoand requested a review from ludeeus as a code owner June 25, 2019 17:22

homeassistant added cla-error core integration: traccar labels Jun 25, 2019

ghost assigned ludeeus Jun 25, 2019

escoand changed the title ~~Traccar webhook~~ Webhook for Traccar and Osmand Jun 25, 2019

add initial traccar webhook support

b3115d3

escoand force-pushed the traccar_webhook branch from 1b4199f to b3115d3 Compare June 25, 2019 17:27

homeassistant added the cla-signed label Jun 25, 2019

home-assistant deleted a comment from homeassistant Jun 25, 2019

MartinHjelmare added cla-recheck and removed cla-error cla-signed labels Jun 25, 2019

homeassistant removed the cla-recheck label Jun 25, 2019

MartinHjelmare added the cla-recheck label Jun 25, 2019

homeassistant added cla-signed and removed cla-recheck labels Jun 25, 2019

escoand added 2 commits June 25, 2019 20:14

remove unused import

01083b0

add tests but disabled atm

2b97d75

escoand mentioned this pull request Jun 26, 2019

Webhook support for GET requests #24772

Closed

balloob reviewed Jun 26, 2019

View reviewed changes

homeassistant/components/traccar/.translations/it.json Outdated Show resolved Hide resolved

escoand commented Aug 8, 2019

View reviewed changes

tests/components/traccar/test_init.py Outdated Show resolved Hide resolved

rename config_flow

f38b333

escoand changed the title ~~Webhook for Traccar and Osmand~~ Webhook for Traccar Aug 8, 2019

escoand added 2 commits August 8, 2019 21:37

format using black

0c7e4dc

format tests using black

e126b4b

MartinHjelmare reviewed Aug 8, 2019

View reviewed changes

homeassistant/components/traccar/__init__.py Outdated Show resolved Hide resolved

Use str instead of float

8a18c10

escoand force-pushed the traccar_webhook branch from 71603a7 to 8a18c10 Compare August 8, 2019 20:44

escoand mentioned this pull request Aug 8, 2019

Add description for Traccar Client home-assistant/home-assistant.io#10090

Merged

2 tasks

MartinHjelmare requested changes Aug 9, 2019

View reviewed changes

escoand added 5 commits August 9, 2019 15:22

fix most comments

96258a7

check id

5e2a33c

add two device test

1884889

reformat

29619f2

fix failuers

e90b17b

MartinHjelmare reviewed Aug 9, 2019

View reviewed changes

escoand and others added 5 commits August 9, 2019 19:17

Update tests/components/traccar/test_init.py

b2a853a

Co-Authored-By: Martin Hjelmare <marhje52@kth.se>

Update tests/components/traccar/test_init.py

090bc4d

Co-Authored-By: Martin Hjelmare <marhje52@kth.se>

Update tests/components/traccar/test_init.py

c8c729c

Co-Authored-By: Martin Hjelmare <marhje52@kth.se>

Update tests/components/traccar/test_init.py

84f5681

Co-Authored-By: Martin Hjelmare <marhje52@kth.se>

black

a1dd6e5

MartinHjelmare approved these changes Aug 9, 2019

View reviewed changes

MartinHjelmare merged commit dc5c178 into home-assistant:dev Aug 9, 2019

escoand deleted the traccar_webhook branch August 10, 2019 18:42

balloob mentioned this pull request Aug 20, 2019

Add strings for traccar config flow #26089

Merged

alderete mentioned this pull request Feb 2, 2022

Webhooks missing support for GET requests #65348

Closed

Uh oh!

Conversation

escoand commented Jun 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking Change:

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

ghost commented Jun 25, 2019

Uh oh!

Uh oh!

balloob commented Jun 26, 2019

Uh oh!

escoand commented Jun 27, 2019

Uh oh!

escoand commented Jul 16, 2019

Uh oh!

balloob commented Jul 16, 2019

Uh oh!

escoand commented Jul 17, 2019

Uh oh!

escoand commented Jul 18, 2019

Uh oh!

escoand commented Jul 18, 2019

Uh oh!

MartinHjelmare commented Aug 8, 2019

Uh oh!

Uh oh!

escoand commented Aug 8, 2019

Uh oh!

frenck commented Aug 8, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

balloob commented Aug 20, 2019

Uh oh!

balloob commented Aug 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

escoand commented Jun 25, 2019 •

edited

Loading

Example entry for `configuration.yaml` (if applicable):