Allow webhooks that support GET#17782
Allow webhooks that support GET#17782rohankapoorcom wants to merge 1 commit intohome-assistant:devfrom
Conversation
|
I'm not sure if the best approach is to allow each webhook to be used as GET/POST endpoint. I was considering another approach: changing the webhook schema to include an HTTP method in addition to the Thoughts? |
|
Webhooks are not for returning data. If a component wants to expose an endpoint that returns data, they need to define a webview. |
|
@balloob in light of your latest comments on #15376 and #17804, I wanted to bring this one up again. Here's my reasoning for wanting GET based webhooks:
Again, I think we could solve this use case without using the webhook component (if we want to keep that component only for POST requests, by creating a new generalized component (similar to the webhook component) to be used for all these things that need an authenticated webview (but only for GET requests). Personally, I think it's a better solution to allow this case to be handled by the webhook component itself, rather than having two similar components (with slightly similar url schemes) and possible confusion for other developers down the line. Let me know what you think and how you want to move forward. |
|
customer.io uses form encoded, so is POST ? |
|
Webhooks should focus on getting data in, I don't want to increase the scope about getting data out just now. |
|
Okay, sounds good. Let's work on getting all of the inbound webhooks migrated over to the new component and then we can circle back on the things that are using |
Description:
Copying the description from my comment #15376 (comment):
Related issue (if applicable): relates to #15376
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: