Add support for multiple N26 accounts by gorynychzmey · Pull Request #24345 · home-assistant/core

gorynychzmey · 2019-06-06T14:41:12Z

Breaking Change:

Changed generation of unique ids for spaces. Previous format was space_<name>, new format is space_<iban[-4:]_<name>. Otherwise we cannot guarantee uniqueness of ids in case of two accounts have spaces with same name, f.e. "main" spaces have always same name by default.

The stale spaces (with old ids) need to be removed from registry.

Description:

Added support for multiple N26 accounts.

Docs PR:

home-assistant/home-assistant.io#9577

Example entry for `configuration.yaml` (if applicable):

n26:                                                                                                                                                   
    - username: email1@example.com                                                                                                                    
      password: !secret n26_password1                                                                                                                     
    - username: email2@example.com 
      password: !secret n26_password2

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
Untested files have been added to .coveragerc.

If the code does not interact with devices:

Tests have been added to verify that the new code works.

MartinHjelmare · 2019-07-11T10:56:35Z

@@ -15,12 +15,17 @@ def setup_platform(
        hass, config, add_entities, discovery_info=None):
    """Set up the N26 switch platform."""
    api_data = hass.data[DOMAIN][DATA]


Please make all the same changes in this module as above.

I've made all the changes you've mentioned, but can't pass check - it fails for Python 3.7 in module, which I've never thought to change. I suppose that failure is temporary. Can I somehow redo check later?

MartinHjelmare · 2019-07-11T11:02:03Z

Please add to the breaking change paragraph what the user needs to do to cope with the breaking change. In this case, the user needs to remove existing stale entities from the entity registry.

MartinHjelmare · 2019-07-11T14:37:50Z

        hass, config, add_entities, discovery_info=None):
    """Set up the N26 sensor platform."""
-    api_data = hass.data[DOMAIN][DATA]
+    api_list = hass.data[DOMAIN][DATA]


Please add a guard clause here that checks if discovery_info is None and return if so.

MartinHjelmare · 2019-07-11T14:38:25Z

+    api_list = hass.data[DOMAIN][DATA]

-    sensor_entities = [N26Account(api_data)]
+    if api_list is None:


The api_list can never be None. We can remove this.

MartinHjelmare · 2019-07-11T14:38:37Z

-    api_data = hass.data[DOMAIN][DATA]
+    api_list = hass.data[DOMAIN][DATA]
+
+    if api_list is None:


MartinHjelmare · 2019-07-11T14:39:42Z

Please rebase on latest dev branch to let the build pass.

…ytadin component (#24652) * Fix AttributeError: 'NoneType' object has no attribute 'group' * Update sensor.py

* braviatv, nmap_tracker: use getmac for getting MAC addresses Refs #24601 * Move getmac imports to top level

…ors (#24640)

@callback

* Breaking change: Rewrite opentherm_gw to add support for more than one OpenTherm Gateway. Breaks config layout and child entity ids and adds a required parameter to all service calls (gateway_id). * Add schema and parameter description for service opentherm_gw.reset_gateway. * Add optional name attribute in config to be used for friendly names. Fix bugs in binary_sensor and climate platforms. * pylint fixes * Remove unused variables. * Update manifest.json, remove REQUIREMENTS from .py file * Update CODEOWNERS * Address issues that were brought up (requested changes): - Move imports to module level - Change certain functions from async to sync - Move constants to const.py (new file) - Call gateway setup from outside of __init__() - Move validation of monitored_variables to config schema * Address requested changes: - Make module imports relative - Move more functions from async to sync, decorate with @callback where necessary - Remove monitored_variables option, add all sensors by default

@OttoWinter

* Vlc telnet first commit First functional version, remains to add more functionality. * New functions added and bugfixes * Compliance with dev checklist * Compliance with dev checklist * Compliance with pydocstyle * Removed unused import * Fixed wrong reference for exception * Module renamed * Fixed module rename in other * Fixed wrong reference for exception Module renamed Fixed module rename in other * Update homeassistant/components/vlc_telnet/media_player.py Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com> * Update homeassistant/components/vlc_telnet/media_player.py Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com> * Update homeassistant/components/vlc_telnet/media_player.py Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com> * Update homeassistant/components/vlc_telnet/media_player.py Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com> * Suggestions by @OttoWinter +Manage error when the VLC dissapears to show status unavailable. * Removed error log, instead set unavailable state * Changes suggested by @pvizeli -Import location -Use of constants * Implemented available method * Improved available method

* Clean up Google Config * Lint * pylint * pylint2

@OttoWinter

* Vlc telnet first commit First functional version, remains to add more functionality. * New functions added and bugfixes * Compliance with dev checklist * Compliance with dev checklist * Compliance with pydocstyle * Removed unused import * Fixed wrong reference for exception * Module renamed * Fixed module rename in other * Fixed wrong reference for exception Module renamed Fixed module rename in other * Update homeassistant/components/vlc_telnet/media_player.py Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com> * Update homeassistant/components/vlc_telnet/media_player.py Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com> * Update homeassistant/components/vlc_telnet/media_player.py Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com> * Update homeassistant/components/vlc_telnet/media_player.py Accepted suggestion by @OttoWinter Co-Authored-By: Otto Winter <otto@otto-winter.com> * Suggestions by @OttoWinter +Manage error when the VLC dissapears to show status unavailable. * Removed error log, instead set unavailable state * Changes suggested by @pvizeli -Import location -Use of constants * Implemented available method * Improved available method

* Improve autodiscovered yeelights model detection * Lint fixes * Logger warn fix

* Add extra_module_url and extra_module_url_es5 to frontend options * Address review comments

homeassistant added cla-signed integration: n26 labels Jun 6, 2019

gorynychzmey mentioned this pull request Jun 6, 2019

Added config for multiple accounts - N26 home-assistant/home-assistant.io#9577

Merged

2 tasks

MartinHjelmare requested changes Jul 11, 2019

View reviewed changes

MartinHjelmare changed the title ~~Added support for multiple N26 accounts~~ Add support for multiple N26 accounts Jul 11, 2019

MartinHjelmare added the breaking-change label Jul 11, 2019

MartinHjelmare reviewed Jul 11, 2019

View reviewed changes

gorynychzmey requested a review from a team as a code owner July 11, 2019 15:20

andrewsayre and others added 20 commits July 11, 2019 20:39

Bump pysmartthings (#24659)

ea9fba0

Fix AttributeError: 'NoneType' object has no attribute 'group' with s…

428a823

…ytadin component (#24652) * Fix AttributeError: 'NoneType' object has no attribute 'group' * Update sensor.py

braviatv, nmap_tracker: use getmac for getting MAC addresses (#24628)

8f0dcd0

* braviatv, nmap_tracker: use getmac for getting MAC addresses Refs #24601 * Move getmac imports to top level

Fix downloader_download_failed event not firing for HTTP response err…

1d09ea2

…ors (#24640)

Update azure-pipelines-wheels.yml for Azure Pipelines

ffbb782

Update azure-pipelines-wheels.yml for Azure Pipelines

b0c83ed

Clean up Google Config (#24663)

ce84868

* Clean up Google Config * Lint * pylint * pylint2

Prefere binary with wheels (#24669)

25a9ac6

Updated frontend to 20190620.0

8652b80

Updated frontend to 20190620.0

ba84d7f

Bump ZHA dependencies. (#24637)

f4cc860

Upgrade blinkpy==0.14.1 for startup bugfix (#24656)

13eade5

Add device class support for Ambient PWS sensors (#24677)

fb0b40e

Bumped version to 0.95.0b1

229bc3a

Update azure-pipelines-release.yml for Azure Pipelines

2d20ce1

Improve autodiscovered yeelights model detection (#24671)

72ac0b7

* Improve autodiscovered yeelights model detection * Lint fixes * Logger warn fix

Allow extra js modules to be included in frontend (#24675)

cc2337c

* Add extra_module_url and extra_module_url_es5 to frontend options * Address review comments

gorynychzmey requested a review from a team July 11, 2019 18:52

gorynychzmey requested a review from a team as a code owner July 11, 2019 18:52

gorynychzmey closed this Jul 11, 2019

gorynychzmey mentioned this pull request Jul 11, 2019

Add support for multiple N26 accounts #25086

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add support for multiple N26 accounts#24345

Add support for multiple N26 accounts#24345
gorynychzmey wants to merge 620 commits into
home-assistant:devfrom
gorynychzmey:dev

gorynychzmey commented Jun 6, 2019 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MartinHjelmare Jul 11, 2019

Uh oh!

gorynychzmey Jul 11, 2019

Uh oh!

MartinHjelmare commented Jul 11, 2019

Uh oh!

MartinHjelmare Jul 11, 2019

Uh oh!

MartinHjelmare Jul 11, 2019

Uh oh!

MartinHjelmare Jul 11, 2019

Uh oh!

MartinHjelmare commented Jul 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

gorynychzmey commented Jun 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking Change:

Description:

Docs PR:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MartinHjelmare Jul 11, 2019

Choose a reason for hiding this comment

Uh oh!

gorynychzmey Jul 11, 2019

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare commented Jul 11, 2019

Uh oh!

MartinHjelmare Jul 11, 2019

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare Jul 11, 2019

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare Jul 11, 2019

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare commented Jul 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

gorynychzmey commented Jun 6, 2019 •

edited

Loading

Example entry for `configuration.yaml` (if applicable):