Fix downloader_download_failed event not firing for HTTP response errors#24640
Merged
Conversation
Contributor
Author
|
I associated the commit email with my GitHub user. Let me know if additional steps are necessary. |
balloob
approved these changes
Jun 20, 2019
Member
|
Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix downloader_download_failed event not firing for HTTP response errors
The Downloader component documentation at https://www.home-assistant.io/components/downloader/ says:
However currently the event is only fired if there's a ConnectionError exception, and not if the download fails due to a non-200 HTTP response code. Only a warning is logged. According to the docs, this case should also fire a downloader_download_failed event. This PR adds that event.
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: