Skip to content

Move I/O to executor thread pool #23589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bachya merged 4 commits into from
May 1, 2019
Merged

Move I/O to executor thread pool #23589

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
09b0def
Move I/O to executor thread pool
cyrosy May 1, 2019
a5bc3d8
Check if image is in whitelist_external_dir
cyrosy May 1, 2019
86cdfaf
Move import to top of file
cyrosy May 1, 2019
1a193b8
Fix bad indentation
cyrosy May 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions homeassistant/components/discord/notify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ def __init__(self, hass, token):
self.token = token
self.hass = hass

def file_exists(self, filename):
import os.path
Comment thread
cyrosy marked this conversation as resolved.
Outdated

return os.path.isfile(filename)

async def async_send_message(self, message, **kwargs):
"""Login to Discord, send message to channel(s) and log out."""
import discord
Expand All @@ -49,11 +54,14 @@ async def async_send_message(self, message, **kwargs):
data = kwargs.get(ATTR_DATA)

if ATTR_IMAGES in data:
import os.path
images = list()

for image in data.get(ATTR_IMAGES):
if os.path.isfile(image):
image_exists = await self.hass.async_add_executor_job(
self.file_exists,
Comment thread
cyrosy marked this conversation as resolved.
Outdated
image)

if image_exists:
images.append(image)
else:
_LOGGER.warning("Image not found: %s", image)
Expand Down