Skip to content

Move I/O to executor thread pool#23589

Merged
bachya merged 4 commits into
home-assistant:devfrom
cyrosy:feat/update-discrodpy
May 1, 2019
Merged

Move I/O to executor thread pool#23589
bachya merged 4 commits into
home-assistant:devfrom
cyrosy:feat/update-discrodpy

Conversation

@cyrosy
Copy link
Copy Markdown
Contributor

@cyrosy cyrosy commented May 1, 2019

Breaking Change:

The images passed to the payload must be within a whitelisted external dir

Description:

Change requested by @MartinHjelmare on my previous PR #23523

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Copy link
Copy Markdown
Contributor

@amelchio amelchio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are at it, I think this should probably check whitelist_external_dirs ?

@cyrosy
Copy link
Copy Markdown
Contributor Author

cyrosy commented May 1, 2019

@amelchio check added, I edited the PR to add a BC description : old payload with images outside of whitelist_external_dirs would not work as before

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Just move the import.

Comment thread homeassistant/components/discord/notify.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when build passes.

Comment thread homeassistant/components/discord/notify.py Outdated
@bachya bachya merged commit beb678e into home-assistant:dev May 1, 2019
@cyrosy cyrosy deleted the feat/update-discrodpy branch May 2, 2019 06:41
@balloob balloob mentioned this pull request May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants