Move I/O to executor thread pool#23589
Merged
Merged
Conversation
amelchio
reviewed
May 1, 2019
Contributor
amelchio
left a comment
There was a problem hiding this comment.
While you are at it, I think this should probably check whitelist_external_dirs ?
Contributor
Author
|
@amelchio check added, I edited the PR to add a BC description : old payload with images outside of whitelist_external_dirs would not work as before |
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Good! Just move the import.
MartinHjelmare
approved these changes
May 1, 2019
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Can be merged when build passes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
The images passed to the payload must be within a whitelisted external dir
Description:
Change requested by @MartinHjelmare on my previous PR #23523
Checklist:
tox. Your PR cannot be merged unless tests passIf the code communicates with devices, web services, or third-party tools:
requirementsin the manifest (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.