Name sensors correctly#23208
Merged
awarecan merged 2 commits intoApr 19, 2019
Merged
Conversation
homeassistant
added
integration: hue
small-pr
ghost
assigned
|
Hey there @balloob, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
5 tasks
balloob
approved these changes
Apr 18, 2019
mitchellrj
force-pushed
the
add-basic-hue-sensor-support
branch
from
2b4bd25 to
8306fa2
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## dev #23208 +/- ##
=========================================
- Coverage 94.3% 94.21% -0.09%
=========================================
Files 457 457
Lines 37106 37085 -21
=========================================
- Hits 34991 34938 -53
- Misses 2115 2147 +32
Continue to review full report at Codecov.
|
Contributor
Author
|
No matter how long I do development, I still regularly fall into the trap of "it's just a small change, I won't run the tests before I push"... |
balloob
pushed a commit
that referenced
this pull request
Apr 20, 2019
* Hue motion senors are motion sensors, not presence sensors. * Name the sensors 'motion' instead of 'presence' - match the HA paradigm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponds with #23193.