Skip to content

Don't use room setpoint override in climate.opentherm_gw #22656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robbiet480 merged 3 commits into from
Apr 2, 2019
Merged

Don't use room setpoint override in climate.opentherm_gw #22656

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a88f304
Dont use DATA_ROOM_SETPOINT_OVRD in climate.opentherm_gw as it is unr…
mvn23 Mar 28, 2019
d317e56
Show new target temperature immediately until the backend notices a c…
mvn23 Mar 29, 2019
579b0b0
Only update target temp on the gateway if the value differs from the …
mvn23 Mar 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions homeassistant/components/opentherm_gw/climate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ def __init__(self, hass, config):
self.temp_precision = config.get(CONF_PRECISION)
self._current_operation = STATE_IDLE
self._current_temperature = None
self._new_target_temperature = None
Comment thread
MartinHjelmare marked this conversation as resolved.
self._target_temperature = None
self._away_mode_a = None
self._away_mode_b = None
Expand All @@ -63,11 +64,10 @@ async def receive_report(self, status):
else:
self._current_operation = STATE_IDLE
self._current_temperature = status.get(self._gw_vars.DATA_ROOM_TEMP)

temp = status.get(self._gw_vars.DATA_ROOM_SETPOINT_OVRD)
if temp is None:
temp = status.get(self._gw_vars.DATA_ROOM_SETPOINT)
self._target_temperature = temp
temp_upd = status.get(self._gw_vars.DATA_ROOM_SETPOINT)
if self._target_temperature != temp_upd:
self._new_target_temperature = None
self._target_temperature = temp_upd

# GPIO mode 5: 0 == Away
# GPIO mode 6: 1 == Away
Expand Down Expand Up @@ -138,7 +138,7 @@ def current_temperature(self):
@property
def target_temperature(self):
"""Return the temperature we try to reach."""
return self._target_temperature
return self._new_target_temperature or self._target_temperature

@property
def target_temperature_step(self):
Expand All @@ -154,7 +154,9 @@ async def async_set_temperature(self, **kwargs):
"""Set new target temperature."""
if ATTR_TEMPERATURE in kwargs:
temp = float(kwargs[ATTR_TEMPERATURE])
self._target_temperature = await self._gateway.set_target_temp(
if temp == self.target_temperature:
return
self._new_target_temperature = await self._gateway.set_target_temp(
temp)
self.async_schedule_update_ha_state()

Expand Down