Don't use room setpoint override in climate.opentherm_gw#22656
Merged
Conversation
…eliable with some thermostats.
…current target_temperature.
homeassistant
added
cla-signed
integration: opentherm_gw
small-pr
ghost
added
the
Codecov Report
@@ Coverage Diff @@
## dev #22656 +/- ##
=======================================
Coverage 92.57% 92.57%
=======================================
Files 457 457
Lines 36977 36977
=======================================
Hits 34232 34232
Misses 2745 2745Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## dev #22656 +/- ##
=======================================
Coverage 92.57% 92.57%
=======================================
Files 457 457
Lines 36977 36977
=======================================
Hits 34232 34232
Misses 2745 2745Continue to review full report at Codecov.
|
Contributor
|
Can confirm as a main debugger ;-) that the code works and fixes situation with iSense thermostat (while gateway in iSense mode too). Tested and stable. |
balloob
pushed a commit
that referenced
this pull request
Apr 3, 2019
* Dont use DATA_ROOM_SETPOINT_OVRD in climate.opentherm_gw as it is unreliable with some thermostats. * Show new target temperature immediately until the backend notices a change * Only update target temp on the gateway if the value differs from the current target_temperature.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
While troubleshooting some issues in the pyotgw library, it was noted that the room setpoint override (DATA_ROOM_SETP_OVRD) does not always provide reliable data with some thermostats. To fix this, we only use the actual current setpoint as reported by the thermostat. When setting an override (changing the target temperature through HA), the thermostat takes some time to update its setpoint. To bridge this gap, we assume the override value as target temperature until the thermostat changes the setpoint.
Related issue (if applicable): N/A
Pull request in home-assistant.io with documentation (if applicable): N/A
Example entry for
configuration.yaml(if applicable):N/A
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: