Skip to content

Hass.io discovery flow deconz#22623

Merged
balloob merged 7 commits intodevfrom
flow-deconz
Apr 3, 2019
Merged

Hass.io discovery flow deconz#22623
balloob merged 7 commits intodevfrom
flow-deconz

Conversation

@pvizeli
Copy link
Copy Markdown
Member

@pvizeli pvizeli commented Apr 1, 2019

Description:

Support Add-ons to trigger a config flow for deCONZ gateway. It works analog mqtt from @balloob.

  • Tests

Copy link
Copy Markdown
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small issues, lacks test. Overall it looks good 👍

I'd like to see #22449 merged first though, I'd like to not need to rebase all of it on top of this

Comment thread homeassistant/components/deconz/config_flow.py Outdated
Comment thread homeassistant/components/deconz/config_flow.py
user_input[CONF_ALLOW_DECONZ_GROUPS],
})

return self.async_show_form(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed with #22449 So no need to introduce that configuration

Comment thread homeassistant/components/deconz/config_flow.py
Comment thread homeassistant/components/deconz/config_flow.py
@Kane610
Copy link
Copy Markdown
Member

Kane610 commented Apr 1, 2019

Just tests left 👍

@pvizeli pvizeli added this to the 0.91.0 milestone Apr 2, 2019
Copy link
Copy Markdown
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@balloob balloob merged commit 5613e8b into dev Apr 3, 2019
@ghost ghost removed the in progress label Apr 3, 2019
@delete-merged-branch delete-merged-branch Bot deleted the flow-deconz branch April 3, 2019 02:23
balloob pushed a commit that referenced this pull request Apr 3, 2019
* Add Hass.io deCONZ discovery flow

* add bridge ID

* fix attribute

* fix strings

* Address comments

* Add test

* Add only instance / changed maybe later
@balloob balloob mentioned this pull request Apr 3, 2019
jonbeckman pushed a commit to jonbeckman/home-assistant that referenced this pull request Apr 7, 2019
* Add Hass.io deCONZ discovery flow

* add bridge ID

* fix attribute

* fix strings

* Address comments

* Add test

* Add only instance / changed maybe later
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants