Skip to content

Support multiple deCONZ gateways#22449

Merged
awarecan merged 24 commits intohome-assistant:devfrom
Kane610:deconz-support-multiple-gateways
Apr 5, 2019
Merged

Support multiple deCONZ gateways#22449
awarecan merged 24 commits intohome-assistant:devfrom
Kane610:deconz-support-multiple-gateways

Conversation

@Kane610
Copy link
Copy Markdown
Member

@Kane610 Kane610 commented Mar 26, 2019

Breaking Change:

Description:

In preparation for the soon to be released Conbee 2 and for all users wanting to migrate in an orderly fashion.

  • Fix storing of gateways in hass.data
  • Fix signalling of reachable gateways
  • Fix signalling of new events
  • Fix designating master gateway for services
  • Fix unload entry
  • Fix services handling multiple gateways

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Comment thread tests/components/deconz/test_init.py Outdated
@pergolafabio
Copy link
Copy Markdown

Where do you see that info about a new conbee?

@fabaff fabaff changed the title deCONZ - support multiple gateways Support multiple deCONZ gateways Mar 27, 2019
@Hedda
Copy link
Copy Markdown
Contributor

Hedda commented Mar 29, 2019

@pergolafabio More than one reseller has leaked that "ConBee II" hardware will be released (very soon).

@Kane610 Kane610 force-pushed the deconz-support-multiple-gateways branch from 45bc31b to c8fe52b Compare March 29, 2019 19:08
Comment thread tests/components/deconz/test_init.py Outdated
@Kane610 Kane610 marked this pull request as ready for review March 30, 2019 22:08
@Kane610 Kane610 mentioned this pull request Apr 1, 2019
1 task
@Kane610 Kane610 force-pushed the deconz-support-multiple-gateways branch from 8161d8f to eb0e7f3 Compare April 3, 2019 16:45
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2019

Codecov Report

Merging #22449 into dev will decrease coverage by <.01%.
The diff coverage is 95.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22449      +/-   ##
==========================================
- Coverage   93.83%   93.83%   -0.01%     
==========================================
  Files         449      449              
  Lines       36558    36574      +16     
==========================================
+ Hits        34305    34319      +14     
- Misses       2253     2255       +2
Impacted Files Coverage Δ
homeassistant/components/deconz/sensor.py 95.89% <100%> (ø) ⬆️
homeassistant/components/deconz/const.py 100% <100%> (ø) ⬆️
homeassistant/components/deconz/switch.py 100% <100%> (ø) ⬆️
homeassistant/components/deconz/climate.py 98.18% <100%> (ø) ⬆️
homeassistant/components/deconz/light.py 100% <100%> (ø) ⬆️
homeassistant/components/deconz/deconz_device.py 100% <100%> (ø) ⬆️
homeassistant/components/deconz/binary_sensor.py 91.66% <100%> (ø) ⬆️
homeassistant/components/deconz/cover.py 100% <100%> (ø) ⬆️
homeassistant/components/deconz/scene.py 100% <100%> (ø) ⬆️
homeassistant/components/deconz/config_flow.py 97.77% <90.47%> (-0.19%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3872ac9...70a558b. Read the comment docs.

@awarecan awarecan merged commit b50afec into home-assistant:dev Apr 5, 2019
@ghost ghost removed the Ready for review label Apr 5, 2019
Comment thread homeassistant/components/deconz/__init__.py
Comment thread homeassistant/components/deconz/__init__.py
Comment thread homeassistant/components/deconz/gateway.py
@Kane610
Copy link
Copy Markdown
Member Author

Kane610 commented Apr 5, 2019

@MartinHjelmare I will create a follow up PR to fix your comments, if you plan to review it more, I can ofc wait till you're done.

@MartinHjelmare
Copy link
Copy Markdown
Member

I'm done, thanks.

@Kane610 Kane610 mentioned this pull request Apr 5, 2019
3 tasks
@Kane610 Kane610 deleted the deconz-support-multiple-gateways branch April 5, 2019 17:15
@Anonym-tsk
Copy link
Copy Markdown
Contributor

@Kane610 You removed async_step_options from config_flow.py.
How now i can to change allow_clip_sensor and allow_deconz_groups properties?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants