Skip to content

Remove index#21304

Merged
amelchio merged 2 commits into
devfrom
loader
Feb 22, 2019
Merged

Remove index#21304
amelchio merged 2 commits into
devfrom
loader

Conversation

@fabaff
Copy link
Copy Markdown
Member

@fabaff fabaff commented Feb 22, 2019

Description:

Remove index.

Fixes error introduces by #21287.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@fabaff fabaff requested a review from a team as a code owner February 22, 2019 09:28
@homeassistant homeassistant added cla-signed core small-pr PRs with less than 30 lines. labels Feb 22, 2019
@ghost ghost assigned fabaff Feb 22, 2019
@ghost ghost added the in progress label Feb 22, 2019
Comment thread homeassistant/loader.py Outdated

for index, path in enumerate('{}.{}'.format(base, comp_or_platform)
for base in base_paths):
for _, path in enumerate('{}.{}'.format(base, comp_or_platform)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't need the index we don't need to use enumerate.

@fbradyirl
Copy link
Copy Markdown
Contributor

LGTM. Will be great to get the pipeline working thanks @fabaff

Copy link
Copy Markdown
Contributor

@amelchio amelchio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's merge this so the build gets fixed.

@amelchio amelchio merged commit 3f29e91 into dev Feb 22, 2019
@delete-merged-branch delete-merged-branch Bot deleted the loader branch February 22, 2019 13:11
@ghost ghost removed the in progress label Feb 22, 2019
@balloob balloob mentioned this pull request Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed core small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants