Skip to content

Do not warn for internally loaded components#21287

Merged
balloob merged 1 commit into
devfrom
fix-fake-warnings
Feb 21, 2019
Merged

Do not warn for internally loaded components#21287
balloob merged 1 commit into
devfrom
fix-fake-warnings

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Feb 21, 2019

Description:

In #21070 I made a mistake by using the externally facing get_component inside get_platform, causing a warning to be printed for errors that were expected.

This fixes it. It also fixes the custom component warning.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner February 21, 2019 22:46
@homeassistant homeassistant added cla-signed core small-pr PRs with less than 30 lines. labels Feb 21, 2019
@ghost ghost assigned balloob Feb 21, 2019
@ghost ghost added the in progress label Feb 21, 2019
@balloob balloob merged commit ac50298 into dev Feb 21, 2019
@ghost ghost removed the in progress label Feb 21, 2019
@delete-merged-branch delete-merged-branch Bot deleted the fix-fake-warnings branch February 21, 2019 22:57
@SukramJ
Copy link
Copy Markdown
Contributor

SukramJ commented Feb 22, 2019

I think this PR causes a lint in dev:
homeassistant/loader.py:163:8: W0612: Unused variable 'index' (unused-variable)

Thats why my PR build #21241 fails in travis. Others are affected too.

@fabaff fabaff mentioned this pull request Feb 22, 2019
1 task
@balloob balloob mentioned this pull request Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed core small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants