Skip to content

Xfinity Gateway device_tracker platform#21026

Merged
rohankapoorcom merged 8 commits into
home-assistant:devfrom
cisasteelersfan:dev
Mar 5, 2019
Merged

Xfinity Gateway device_tracker platform#21026
rohankapoorcom merged 8 commits into
home-assistant:devfrom
cisasteelersfan:dev

Conversation

@cisasteelersfan
Copy link
Copy Markdown
Contributor

@cisasteelersfan cisasteelersfan commented Feb 13, 2019

Description:

Xfinity Gateway device_tracker platform. On the login page of the gateway, a list of connected devices with MAC address & hostname is displayed. My Pypi package scrapes this page using BeautifulSoup.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8535

Example entry for configuration.yaml (if applicable):

device_tracker:
  platform: xfinity

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Comment thread homeassistant/components/device_tracker/xfinity.py Outdated
Comment thread homeassistant/components/device_tracker/xfinity.py Outdated
Comment thread homeassistant/components/device_tracker/xfinity.py Outdated
Comment thread homeassistant/components/device_tracker/xfinity.py Outdated
@cisasteelersfan cisasteelersfan changed the title WIP Xfinity Gateway device_tracker platform Xfinity Gateway device_tracker platform Feb 13, 2019
Comment thread .coveragerc Outdated
Comment thread homeassistant/components/device_tracker/xfinity.py Outdated
Comment thread homeassistant/components/device_tracker/xfinity.py Outdated
Copy link
Copy Markdown
Member

@rohankapoorcom rohankapoorcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, a few small changes requested.

Comment thread homeassistant/components/device_tracker/xfinity.py Outdated
Comment thread homeassistant/components/device_tracker/xfinity.py Outdated
Comment thread homeassistant/components/device_tracker/xfinity.py Outdated
Comment thread homeassistant/components/device_tracker/xfinity.py Outdated
Copy link
Copy Markdown
Member

@rohankapoorcom rohankapoorcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when build passes.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rohankapoorcom rohankapoorcom merged commit 0e78054 into home-assistant:dev Mar 5, 2019
@ghost ghost removed the in progress label Mar 5, 2019
@balloob balloob mentioned this pull request Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants