Xfinity Gateway device_tracker platform#21026
Merged
Merged
Conversation
houndci-bot
reviewed
Feb 13, 2019
2 tasks
houndci-bot
reviewed
Feb 13, 2019
rohankapoorcom
requested changes
Feb 19, 2019
Member
rohankapoorcom
left a comment
There was a problem hiding this comment.
Overall looks good, a few small changes requested.
MartinHjelmare
requested changes
Feb 24, 2019
rohankapoorcom
approved these changes
Mar 4, 2019
Member
rohankapoorcom
left a comment
There was a problem hiding this comment.
Can be merged when build passes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Xfinity Gateway device_tracker platform. On the login page of the gateway, a list of connected devices with MAC address & hostname is displayed. My Pypi package scrapes this page using BeautifulSoup.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8535
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: