Skip to content

Xfinity gateway device_tracker documentation and logo#8535

Merged
rohankapoorcom merged 3 commits into
home-assistant:nextfrom
cisasteelersfan:next
Mar 5, 2019
Merged

Xfinity gateway device_tracker documentation and logo#8535
rohankapoorcom merged 3 commits into
home-assistant:nextfrom
cisasteelersfan:next

Conversation

@cisasteelersfan
Copy link
Copy Markdown
Contributor

@cisasteelersfan cisasteelersfan commented Feb 13, 2019

Description:

Pull request in home-assistant (if applicable): home-assistant/core#21026

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Feb 13, 2019
@klaasnicolaas klaasnicolaas added new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch has-parent This PR has a parent PR in another repo and removed to-do labels Feb 13, 2019
@frenck frenck added ready-for-review This PR needs to be reviewed in-progress This PR/Issue is currently being worked on and removed ready-for-review This PR needs to be reviewed labels Feb 13, 2019
@cisasteelersfan cisasteelersfan changed the title WIP Xfinity gateway device_tracker documentation and logo Xfinity gateway device_tracker documentation and logo Feb 13, 2019
Copy link
Copy Markdown
Member

@rohankapoorcom rohankapoorcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor changes but overall looks great!

Comment thread source/_components/device_tracker.xfinity.markdown Outdated
Comment thread source/_components/device_tracker.xfinity.markdown Outdated
Copy link
Copy Markdown
Member

@rohankapoorcom rohankapoorcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@rohankapoorcom rohankapoorcom merged commit 4b8326d into home-assistant:next Mar 5, 2019
@ghost ghost removed the in-progress This PR/Issue is currently being worked on label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants