Utility Meter offset defined by a time_period#20926
Merged
Merged
Conversation
2 tasks
houndci-bot
reviewed
Feb 10, 2019
4d9edac to
6495d47
Compare
fabaff
reviewed
Feb 10, 2019
MartinHjelmare
approved these changes
Feb 24, 2019
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Looks good. Just found a typo.
Member
|
Can be merged when conflict is solved and the breaking change is highlighted in a paragraph in the PR description. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Breaking-change: offset is no longer an integer value dependent on the cycle, but a a very flexible time_period.
Currently offset configuration parameter is an integer that limits daily cycles to have offsets in days, monthly cycles to have offsets in months, etc.
This PR increases the flexibility of offset by making it a time_period that can be described in a combination of hours, days, months, etc. This makes it possible for a yearly cycle to start at a given day of a given month.
It causes a breaking change, but since the component is very recent (0.87) I believe users will acknowledge the improvement and fix the configuration.
Related issue (if applicable): fixes #20918
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8459
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices: