Change type of offset in utility_meter#8459
Merged
Merged
Conversation
ghost
assigned
5 tasks
klaasnicolaas
added
enhancement
current
klaasnicolaas
requested changes
Feb 10, 2019
Contributor
Author
|
@klaasnicolaas tks! |
klaasnicolaas
previously approved these changes
Feb 11, 2019
klaasnicolaas
added
awaits-parent
Member
|
@dgomes looks like there's a merge conflict with the file now, otherwise I think the backend and this PR are ready to merge. Guessing it will land in 0.90? |
Contributor
Author
|
@cgarwood thanks for the heads up Beta was already cut, don't think it qualifies as a bug fix to be fit in 0.89 |
cgarwood
approved these changes
Mar 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Updates the type of offset from integer to time and provides an example of how to define a Time period (copy&paste from sensor.darksky)
Pull request in home-assistant (if applicable): home-assistant/core#20926
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.