Deprecate conf_update_interval#20924
Merged
MartinHjelmare merged 6 commits intoFeb 17, 2019
Merged
Conversation
rohankapoorcom
requested review from
a team,
Danielhiversen and
fabaff
as code owners
ghost
assigned
dgomes
approved these changes
Feb 12, 2019
rohankapoorcom
force-pushed
the
deprecate-conf-update-interval
branch
from
a73384a to
4efa9b2
Compare
rohankapoorcom
force-pushed
the
deprecate-conf-update-interval
branch
from
065ecc1 to
b7eb0ab
Compare
2 tasks
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
The platform schema already has CONF_SCAN_INTERVAL so we should not overwrite that key in platforms.
Member
|
Is this a fix and that's why it should go into 0.88? |
Member
Author
No, I'm trying to place all of the configuration deprecations in a single release (there's already one in 0.88) so that it easier for users to remember when the deprecations became forcibly invalid. All changes addressed and pushed up. |
MartinHjelmare
approved these changes
Feb 17, 2019
Member
|
Nice! |
balloob
pushed a commit
that referenced
this pull request
Feb 17, 2019
* Deprecate update_interval and replace with scan_interval * Update tests * Fix Darksky tests * Fix Darksky tests correctly This reverts commit a73384a. * Provide the default for the non deprecated option * Don't override default schema for sensors
Merged
5 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
As noticed in #20526 ,
CONF_UPDATE_INTERVALandCONF_SCAN_INTERVALserve identical purposes andCONF_SCAN_INTERVALis used a lot more.Now that we have a clean way to deprecate configs without causing breaking changes, (#20565) we can clean this up.
CONF_UPDATE_INTERVALhas been deprecated in 0.88 and is set to become invalid in 0.91 (three versions out). In 0.92, we can go ahead and do a final cleanup since all users should have migrated over by then.Breaking Change:
update_intervalhas been deprecated and replaced withscan_intervalin all components and platforms. This is a soft deprecation in this release and will automatically become a hard breaking change in Home Assistant version 0.91.0.Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8603
I need to go through all of these components/platforms and update the documentation.Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: