Skip to content

Allow configuration of update interval for ness_alarm#21415

Merged
rohankapoorcom merged 7 commits into
home-assistant:devfrom
nickw444:nwhyte-ness-alarm-update-interval
Mar 4, 2019
Merged

Allow configuration of update interval for ness_alarm#21415
rohankapoorcom merged 7 commits into
home-assistant:devfrom
nickw444:nwhyte-ness-alarm-update-interval

Conversation

@nickw444
Copy link
Copy Markdown
Contributor

Description:

Allow users to configure the polling update interval of the component. ref: https://community.home-assistant.io/t/ness-dx8-dx16-alarm/23285/90?u=nickw444

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8720

Example entry for configuration.yaml (if applicable):

ness_alarm:
  host: alarm.home
  port: 8234
  update_interval:
    seconds: 10
  zones:
    - name: Garage
      id: 1
    - name: Storeroom
      id: 2

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@fabaff fabaff changed the title ness_alarm: Allow configuration of update_interval Allow configuration of update interval for ness_alarm Feb 25, 2019
Comment thread homeassistant/components/ness_alarm/__init__.py Outdated
Copy link
Copy Markdown
Member

@rohankapoorcom rohankapoorcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for using scan_interval instead of update_interval.

@rohankapoorcom rohankapoorcom merged commit 10e334c into home-assistant:dev Mar 4, 2019
@ghost ghost removed the in progress label Mar 4, 2019
@nickw444 nickw444 deleted the nwhyte-ness-alarm-update-interval branch March 4, 2019 08:07
@balloob balloob mentioned this pull request Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants