Skip to content

Fix unused friendly name for SolarEdge sensor #20109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvizeli merged 1 commit into from
Jan 18, 2019
Merged

Fix unused friendly name for SolarEdge sensor #20109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions homeassistant/components/sensor/solaredge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@
# Supported sensor types:
# Key: ['json_key', 'name', unit, icon]
SENSOR_TYPES = {
'life_time_data': ['lifeTimeData', "Lifetime energy", 'Wh',
'mdi:solar-power'],
'last_year_data': ['lastYearData', "Energy this year", 'Wh',
'mdi:solar-power'],
'last_month_data': ['lastMonthData', "Energy this month", 'Wh',
'lifetime_energy': ['lifeTimeData', "Lifetime energy", 'Wh',
'mdi:solar-power'],
'last_day_data': ['lastDayData', "Energy today", 'Wh',
'mdi:solar-power'],
'energy_this_year': ['lastYearData', "Energy this year", 'Wh',
'mdi:solar-power'],
'energy_this_month': ['lastMonthData', "Energy this month", 'Wh',
'mdi:solar-power'],
'energy_today': ['lastDayData', "Energy today", 'Wh',
'mdi:solar-power'],
'current_power': ['currentPower', "Current Power", 'W',
'mdi:solar-power']
}
Expand Down Expand Up @@ -106,7 +106,8 @@ def __init__(self, platform_name, sensor_key, data):
@property
def name(self):
"""Return the name."""
return "{}_{}".format(self.platform_name, self.sensor_key)
return "{} ({})".format(self.platform_name,
SENSOR_TYPES[self.sensor_key][1])

@property
def unit_of_measurement(self):
Expand Down