Fix unused friendly name for SolarEdge sensor

[LouisMT]

Description:

The SolarEdge component currently creates sensors named like SolarEdge_current_power in the front end, while an unused array containing friendly names exists in the code. This PR uses this array to set a friendly name.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8193

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

Breaking changes:

This PR changes the entity names of this sensor and the monitoring condition keys in the configuration:

Old entity name	New entity name
sensor.solaredge_current_power	sensor.solaredge_current_power
sensor.solaredge_last_day_data	sensor.solaredge_energy_today
sensor.solaredge_last_month_data	sensor.solaredge_energy_this_month
sensor.solaredge_last_year_data	sensor.solaredge_energy_this_year
sensor.solaredge_life_time_data	sensor.solaredge_lifetime_energy

[homeassistant]

Hi @LouisMT,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[LouisMT]

I'll try to test this soon.

If user exposed functionality or configuration variables are added/changed

I think this will change the generated keys as well (sensor.solaredge_last_day_data -> sensor.solaredge_energy_today). Should this be noted in the documentation?

[MartinHjelmare]

This is a breaking change. Please verify how the entity_id will change for all sensor types, and update the documentation as necessary.

[MartinHjelmare]

Please add a paragraph in the PR description about the breaking change for the release notes.

[LouisMT]

To avoid confusion I've also changed the monitoring condition keys in the configuration to reflect the new sensor names. I've opened a PR for the documentation and noted breaking changes in this PR.

[MartinHjelmare]

Great! Can be merged when build passes.