Add Google pubsub component#20049
Merged
Merged
Conversation
ghost
added
the
timvancann
force-pushed
the
google_pubsub
branch
from
b36a9cc to
c6dd89a
Compare
Contributor
|
Hi @timvancann, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
houndci-bot
reviewed
Jan 13, 2019
2 tasks
fabaff
reviewed
Jan 13, 2019
timvancann
force-pushed
the
google_pubsub
branch
from
2495b7d to
31a58ca
Compare
timvancann
force-pushed
the
google_pubsub
branch
from
ec149de to
e968410
Compare
amelchio
requested changes
Feb 8, 2019
Contributor
amelchio
left a comment
amelchio
left a comment
There was a problem hiding this comment.
This looks really good 👍. Just a couple of comments ...
| _LOGGER.error("Path to credentials file cannot be found") | ||
| return False | ||
|
|
||
| os.environ['GOOGLE_APPLICATION_CREDENTIALS'] = service_principal_path |
Contributor
There was a problem hiding this comment.
Is there some way to pass this without modifying the global environment?
Contributor
Author
There was a problem hiding this comment.
Did some digging, and yes, there is 😄. Fixed it
| """Implement encoding logic.""" | ||
| if isinstance(o, datetime.datetime): | ||
| return o.isoformat() | ||
| return super(DateTimeJSONEncoder, self).default(o) |
Contributor
There was a problem hiding this comment.
I think super() is enough with Python 3.
Contributor
Author
There was a problem hiding this comment.
Absolutely right.
| """Activate Google Pub/Sub component.""" | ||
| from google.cloud import pubsub_v1 # pylint: disable=E0611 | ||
|
|
||
| config = yaml_config.get(DOMAIN, {}) |
Member
There was a problem hiding this comment.
When would the DOMAIN key be missing in the config dict? Why do we need to use dict.get?
Contributor
Author
There was a problem hiding this comment.
It shouldn't be missing. Changed it to dict[]
| class DateTimeJSONEncoder(json.JSONEncoder): | ||
| """Encode python objects. | ||
|
|
||
| Additonaly add encoding for datetime objects as isoformat. |
- Remove pylint ignores - Don't modify global environment
timvancann
force-pushed
the
google_pubsub
branch
from
cea6658 to
c08a13a
Compare
MartinHjelmare
approved these changes
Feb 10, 2019
amelchio
approved these changes
Feb 10, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This adds the Google Pub/Sub component to directly post event changes from Home Assistant to Pub/Sub. This allows for many streaming applications, from cloud dashboarding to cloud data science.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8153
Example entry for
configuration.yaml(if applicable):See new documentation
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: