Skip to content

Google pubsub#8153

Merged
frenck merged 11 commits into
home-assistant:nextfrom
timvancann:google_pubsub
Feb 11, 2019
Merged

Google pubsub#8153
frenck merged 11 commits into
home-assistant:nextfrom
timvancann:google_pubsub

Conversation

@timvancann
Copy link
Copy Markdown
Contributor

@timvancann timvancann commented Jan 13, 2019

Description:

Guide for the Home Assistant Google Pub/Sub component.

Pull request in home-assistant (if applicable): home-assistant/core#20049

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@frenck frenck added new-integration This PR adds documentation for a new Home Assistant integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in another repo and removed to-do labels Jan 21, 2019
@ghost ghost assigned frenck Jan 21, 2019
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timvancann Thanks for the PR! Left you one comment, could you please take a look? 👍

Comment thread source/_components/google_pubsub.markdown Outdated
@frenck frenck added in-progress This PR/Issue is currently being worked on and removed ready-for-review This PR needs to be reviewed labels Jan 21, 2019
@frenck frenck assigned timvancann and unassigned frenck Jan 21, 2019
@frenck frenck self-assigned this Jan 22, 2019
@frenck frenck added ready-for-review This PR needs to be reviewed and removed in-progress This PR/Issue is currently being worked on labels Jan 22, 2019
frenck
frenck previously approved these changes Jan 22, 2019
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR @timvancann! 👍

✅ Approved. Can be merged as soon as the parent PR gets merged.
⚠️ The ha_release might need an update before merging this one in.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Jan 22, 2019
@timvancann
Copy link
Copy Markdown
Contributor Author

@frenck Version has been bumped to 0.88. Still waiting for approval of home-assistant/core#20049.

@klaasnicolaas klaasnicolaas added parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels Feb 11, 2019
Comment thread source/_components/google_pubsub.markdown Outdated
@ghost ghost added the to-do label Feb 11, 2019
@frenck frenck merged commit ae4facc into home-assistant:next Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch parent-merged The parent PR has been merged already

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants