Add exception handling to ADS shutdown#19682
Merged
MartinHjelmare merged 3 commits intohome-assistant:devfrom Jan 3, 2019
carstenschroeder:ADSError-patch
Merged
Add exception handling to ADS shutdown#19682MartinHjelmare merged 3 commits intohome-assistant:devfrom carstenschroeder:ADSError-patch
MartinHjelmare merged 3 commits intohome-assistant:devfrom
carstenschroeder:ADSError-patch
Conversation
homeassistant
added
cla-error
integration: ads
small-pr
ghost
added
the
houndci-bot
reviewed
Dec 31, 2018
MartinHjelmare
approved these changes
Jan 3, 2019
MartinHjelmare
changed the title
Merged
kellerza
pushed a commit
to kellerza/ha-core
that referenced
this pull request
Jan 18, 2019
* Added exception handling to ADS shutdown * corrected whitespaces * deleted blank line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes unhandled exception in shutdown of AdsHub
Related issue (if applicable): fixes #18671
Checklist:
tox. Your PR cannot be merged unless tests pass