Skip to content

Fix pulling cpu_temp issue on Odroid#19620

Merged
fabaff merged 1 commit intohome-assistant:devfrom
gipnokote:glances-exynos-patch
Dec 28, 2018
Merged

Fix pulling cpu_temp issue on Odroid#19620
fabaff merged 1 commit intohome-assistant:devfrom
gipnokote:glances-exynos-patch

Conversation

@gipnokote
Copy link
Copy Markdown
Contributor

Description:

This is basically a similar fix as in PR #19404 but for Odroid (at least for Odroid U2 which I have). Similarly to cpu-thermal 1 on Raspberry Pi, termal sensor on Odroid is called exynos-therm 1, so I added it to the Glances component.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@mretegan
Copy link
Copy Markdown
Contributor

I was about to open another pull request to support the Vero 4K that I have. For this one the thermal sensor is called soc_thermal 1. Could this be added to this pull request? Hopefully at some point that list of identifiers will become exhaustive.

@fabaff
Copy link
Copy Markdown
Member

fabaff commented Dec 28, 2018

@mretegan, please open a PR.

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 82d6fe5 into home-assistant:dev Dec 28, 2018
@ghost ghost removed the in progress label Dec 28, 2018
@gipnokote gipnokote deleted the glances-exynos-patch branch December 28, 2018 21:20
@balloob balloob mentioned this pull request Jan 10, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants