Skip to content

Add device_class property to Systemmonitor sensor#19614

Merged
fabaff merged 1 commit intohome-assistant:devfrom
ReneNulschDE:Systemmonitor-add-device_class
Dec 28, 2018
Merged

Add device_class property to Systemmonitor sensor#19614
fabaff merged 1 commit intohome-assistant:devfrom
ReneNulschDE:Systemmonitor-add-device_class

Conversation

@ReneNulschDE
Copy link
Copy Markdown
Contributor

@ReneNulschDE ReneNulschDE commented Dec 28, 2018

Description:

Add the device_class property for the last_boot sensor.

Related issue (if applicable): fixes #19325

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ghost ghost added the in progress label Dec 28, 2018
fabaff
fabaff approved these changes Dec 28, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff merged commit 14c39f7 into home-assistant:dev Dec 28, 2018
@ghost ghost removed the in progress label Dec 28, 2018
@fabaff fabaff changed the title Systemmonitor - add device_class property Add device_class property to Systemmonitor sensor Dec 28, 2018
@Martinvdm
Copy link
Copy Markdown

Martinvdm commented Dec 28, 2018 •
edited
Loading

home-assistant/frontend#2302

@ReneNulschDE ReneNulschDE deleted the Systemmonitor-add-device_class branch December 29, 2018 08:01
@balloob balloob mentioned this pull request Jan 10, 2019
Merged
@poldim
Copy link
Copy Markdown

poldim commented Feb 8, 2019

I'm still having this issue on 0.86.3. None of the format options from home-assistant/frontend#2087 seem to work

        type: entities
        title: HA Docker
        show_header_toggle: false
        entities:
          - entity: sensor.uptime
            name: HA Docker Uptime
            format: relative

Displays as
image

alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019
@ReneNulschDE @alandtse
Systemmonitor - add device_class property (home-assistant#19614)
0bf9aba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabaff fabaff fabaff approved these changes

Assignees

No one assigned

Labels

cla-signed integration: systemmonitor small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Format does not work for last_boot

5 participants

@ReneNulschDE @Martinvdm @poldim @fabaff @homeassistant