Remove global from ZHA application controller#19557
Merged
MartinHjelmare merged 3 commits intohome-assistant:devfrom Dec 25, 2018
Merged
Remove global from ZHA application controller#19557MartinHjelmare merged 3 commits intohome-assistant:devfrom
MartinHjelmare merged 3 commits intohome-assistant:devfrom
Conversation
homeassistant
added
cla-signed
integration: zha
small-pr
ghost
added
the
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Don't we need to access the controller from any other modules?
Contributor
Author
@MartinHjelmare Nope. Everything is handled through events on the listener. |
dshokouhi
pushed a commit
to dshokouhi/home-assistant
that referenced
this pull request
Dec 25, 2018
* remove global from application controller per request * remove unneeded line * don't store controller application in hass.data - review comment
Merged
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Feb 12, 2019
* remove global from application controller per request * remove unneeded line * don't store controller application in hass.data - review comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove global and stash ZHA's application controller in hass.data.
@MartinHjelmare Let me know if this isn't what you were thinking.