Skip to content

Add device registry to MQTT alarm control panel#19331

Merged
emontnemery merged 2 commits intohome-assistant:devfrom
emontnemery:mqtt-device-registry-alarm
Dec 19, 2018
Merged

Add device registry to MQTT alarm control panel#19331
emontnemery merged 2 commits intohome-assistant:devfrom
emontnemery:mqtt-device-registry-alarm

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Dec 15, 2018

Description:

Implements #16943 for alarm_control_panel.mqtt

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7863

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Copy link
Copy Markdown
Member

@OttoWinter OttoWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emontnemery emontnemery force-pushed the mqtt-device-registry-alarm branch from b6b8764 to 1ded63a Compare December 19, 2018 15:38
@emontnemery emontnemery merged commit ae776e2 into home-assistant:dev Dec 19, 2018
@ghost ghost removed the in progress label Dec 19, 2018
@emontnemery emontnemery deleted the mqtt-device-registry-alarm branch December 19, 2018 18:59
dshokouhi pushed a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018
* Add device registry to MQTT alarm control panel

* Add testcase test_entity_id_update
@balloob balloob mentioned this pull request Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants