Add camera selection config to skybell camera#19310
Merged
cgarwood merged 2 commits intohome-assistant:devfrom Dec 17, 2018
Merged
Add camera selection config to skybell camera#19310cgarwood merged 2 commits intohome-assistant:devfrom
cgarwood merged 2 commits intohome-assistant:devfrom
Conversation
2 tasks
Contributor
Author
|
@MartinHjelmare this is a follow up to #19100 (review). I was able to fix the underlying issue, but added some configs to the camera so people could keep the current functionality if they wanted. I'm pretty sure the failed test is unrelated to my change. I'm not sure how to make it rerun to see if it's just a mistake. |
MartinHjelmare
approved these changes
Dec 17, 2018
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Looks good! Can be merged when build passes.
dshokouhi
pushed a commit
to dshokouhi/home-assistant
that referenced
this pull request
Dec 25, 2018
* add camera selection config to skybell camera * code review changes.
Merged
CCOSTAN
pushed a commit
to CCOSTAN/Home-AssistantConfig
that referenced
this pull request
Jan 10, 2019
mishuka0222
added a commit
to mishuka0222/BearStone-SmartHome
that referenced
this pull request
Jul 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Ongoing conversation in #17617 resulted in a better fix. Some people liked the image we used when the original broke, so I am adding a config to let you choose which image to use in Skybell Camera.
Related issue (if applicable): fixes #17617
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7849
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: