Skip to content

Add camera selection config to skybell camera#19310

Merged
cgarwood merged 2 commits intohome-assistant:devfrom
nhorvath:skybell-activity
Dec 17, 2018
Merged

Add camera selection config to skybell camera#19310
cgarwood merged 2 commits intohome-assistant:devfrom
nhorvath:skybell-activity

Conversation

@nhorvath
Copy link
Copy Markdown
Contributor

@nhorvath nhorvath commented Dec 14, 2018

Description:

Ongoing conversation in #17617 resulted in a better fix. Some people liked the image we used when the original broke, so I am adding a config to let you choose which image to use in Skybell Camera.

Related issue (if applicable): fixes #17617

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7849

Example entry for configuration.yaml (if applicable):

camera:
  - platform: skybell
    monitored_conditions:
    - avatar
    - activity
    activity_name: "Last Activity"
    avatar_name: "Current"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@nhorvath
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare this is a follow up to #19100 (review). I was able to fix the underlying issue, but added some configs to the camera so people could keep the current functionality if they wanted.

I'm pretty sure the failed test is unrelated to my change. I'm not sure how to make it rerun to see if it's just a mistake.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can be merged when build passes.

@cgarwood cgarwood merged commit 6adbf3b into home-assistant:dev Dec 17, 2018
@ghost ghost removed the in progress label Dec 17, 2018
dshokouhi pushed a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018
* add camera selection config to skybell camera

* code review changes.
@balloob balloob mentioned this pull request Jan 10, 2019
CCOSTAN pushed a commit to CCOSTAN/Home-AssistantConfig that referenced this pull request Jan 10, 2019
mishuka0222 added a commit to mishuka0222/BearStone-SmartHome that referenced this pull request Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skybell HD Camera

4 participants