Skip to content

[Breaking Change] Cleanup Lutron light component#18650

Merged
balloob merged 1 commit intohome-assistant:devfrom
cdheiser:patch-1
Nov 23, 2018
Merged

[Breaking Change] Cleanup Lutron light component#18650
balloob merged 1 commit intohome-assistant:devfrom
cdheiser:patch-1

Conversation

@cdheiser
Copy link
Copy Markdown
Contributor

Description:

Remove the return value from setup_platform
Convert LutronLight.init to use super() when referencing the parent class.
Change device_state_attributes() to use lowercase snakecase (Rename 'Lutron Integration ID' to 'lutron_integration_id')

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Remove the return value from setup_platform
Convert LutronLight.__init__ to use super() when referencing the parent class.
Change device_state_attributes() to use lowercase snakecase (Rename 'Lutron Integration ID' to 'lutron_integration_id')
@ghost ghost added the in progress label Nov 23, 2018
@balloob balloob merged commit 98f159a into home-assistant:dev Nov 23, 2018
@ghost ghost removed the in progress label Nov 23, 2018
@balloob balloob mentioned this pull request Dec 12, 2018
This was referenced Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants