Skip to content

Add last clean times to xiaomi vacuum#19043

Merged
syssi merged 2 commits intohome-assistant:devfrom
rytilahti:xiaomi_last_clean_time
Dec 5, 2018
Merged

Add last clean times to xiaomi vacuum#19043
syssi merged 2 commits intohome-assistant:devfrom
rytilahti:xiaomi_last_clean_time

Conversation

@rytilahti
Copy link
Copy Markdown
Member

@rytilahti rytilahti commented Dec 5, 2018

Description:

Add start and stop times of the last cleaning, useful for displaying or scheduling based on their value. The keys are the same as used by neato platform:

clean_start: 2018-12-03T14:15:16
clean_stop: 2018-12-03T14:39:19

Continuation of #17558 (can't reopen after a forced push). This is ready to be merged when #19042 gets merged.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

The keys are the same as used by neato platform.
@rytilahti rytilahti requested a review from syssi as a code owner December 5, 2018 15:47
@ghost ghost assigned rytilahti Dec 5, 2018
@ghost ghost added the in progress label Dec 5, 2018
@syssi syssi merged commit bc69309 into home-assistant:dev Dec 5, 2018
@ghost ghost removed the in progress label Dec 5, 2018
@balloob balloob mentioned this pull request Dec 12, 2018
@rytilahti rytilahti deleted the xiaomi_last_clean_time branch December 12, 2018 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants