WIP: Add last clean times to xiaomi vacuum#17558
Closed
rytilahti wants to merge 2 commits intohome-assistant:devfrom
Closed
WIP: Add last clean times to xiaomi vacuum#17558rytilahti wants to merge 2 commits intohome-assistant:devfrom
rytilahti wants to merge 2 commits intohome-assistant:devfrom
Conversation
homeassistant
added
cla-signed
platform: vacuum.xiaomi_miio
small-pr
ghost
assigned
cgtobi
reviewed
Oct 29, 2018
The keys are the same as used by neato platform.
rytilahti
force-pushed
the
xiaomi_last_clean_time
branch
from
68d48c4 to
0d35d27
Compare
rytilahti
changed the title
rytilahti
changed the title
Member
|
Will close this. You can re-open it when upstream PR has been released and included in HA. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keys are the same as used by neato platform.
Description:
Depends on rytilahti/python-miio#413 and a release bump.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: