Skip to content

Fix hangouts notify #18372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 2 commits into from
Nov 11, 2018
Merged

Fix hangouts notify #18372

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53196d5
Remove notify schema from hangouts platform
MartinHjelmare Nov 11, 2018
207c6b0
Fix hangouts service data key value
MartinHjelmare Nov 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions homeassistant/components/notify/hangouts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,12 @@
import voluptuous as vol

from homeassistant.components.notify import (ATTR_TARGET, PLATFORM_SCHEMA,
NOTIFY_SERVICE_SCHEMA,
BaseNotificationService,
ATTR_MESSAGE, ATTR_DATA)

from homeassistant.components.hangouts.const \
import (DOMAIN, SERVICE_SEND_MESSAGE, MESSAGE_DATA_SCHEMA,
TARGETS_SCHEMA, CONF_DEFAULT_CONVERSATIONS)
import (DOMAIN, SERVICE_SEND_MESSAGE, TARGETS_SCHEMA,
CONF_DEFAULT_CONVERSATIONS)

_LOGGER = logging.getLogger(__name__)

Expand All @@ -25,11 +24,6 @@
vol.Required(CONF_DEFAULT_CONVERSATIONS): [TARGETS_SCHEMA]
})

NOTIFY_SERVICE_SCHEMA = NOTIFY_SERVICE_SCHEMA.extend({
vol.Optional(ATTR_TARGET): [TARGETS_SCHEMA],
vol.Optional(ATTR_DATA, default={}): MESSAGE_DATA_SCHEMA
})


def get_service(hass, config, discovery_info=None):
"""Get the Hangouts notification service."""
Expand Down Expand Up @@ -61,8 +55,9 @@ def send_message(self, message="", **kwargs):
service_data = {
ATTR_TARGET: target_conversations,
ATTR_MESSAGE: messages,
ATTR_DATA: kwargs[ATTR_DATA]
}
if kwargs[ATTR_DATA]:
service_data[ATTR_DATA] = kwargs[ATTR_DATA]

return self.hass.services.call(
DOMAIN, SERVICE_SEND_MESSAGE, service_data=service_data)