Add safe_mode HomeKit (for pairing)#18356
Merged
cdce8p merged 1 commit intohome-assistant:devfrom Nov 16, 2018
cdce8p:homekit-update_safe-mode
Merged
Add safe_mode HomeKit (for pairing)#18356cdce8p merged 1 commit intohome-assistant:devfrom cdce8p:homekit-update_safe-mode
cdce8p merged 1 commit intohome-assistant:devfrom
cdce8p:homekit-update_safe-mode
Conversation
* Use: 'safe_mode: True' in case of pairing issues
2 tasks
Merged
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add
safe_modeoption to HomeKit component. Settingsafe_mode: Truewill allow pairing even if you previously got stuck after entering the pincode and error msg inside the Home App. With this PR it's no longer necessary to change python files like (old method #14567).Important No.1: In order to find the
Home Assistant Bridgewhen you have already tried the default before, you need to delete the.homekit.statefile inside yourconfigdictionary.Important No.2: If you unpair the Bridge, you need to restart Home Assistant to start pairing again.
The
safe_modeoption does only effectpairingandunpairing. Although not recommended, it's safe to leave atTrueduring normal use.Related issue:
#14567
#17181
This PR requires #18355 to be merged first. The necessary function was added with HAP-python 2.4.0. For testing proposes I've include the commit here as well. I'll do the rebase once the other is merged.Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7516
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass