Skip to content

Update pyruter to 1.1.0 to be able to reuse aiohttp session.#18310

Merged
cgarwood merged 2 commits intohome-assistant:devfrom
ludeeus:sensor.ruter_reuse_session
Nov 7, 2018
Merged

Update pyruter to 1.1.0 to be able to reuse aiohttp session.#18310
cgarwood merged 2 commits intohome-assistant:devfrom
ludeeus:sensor.ruter_reuse_session

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Nov 7, 2018

Description:

This updates pyruter to be able to reuse the aiohttp session as discussed in the comments here #18237 (comment)
Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

sensor:
  platform: ruter
  stop_id: 2190400

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Nov 7, 2018
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare
Copy link
Copy Markdown
Member

Can be merged when build passes.

@cgarwood cgarwood merged commit 0bf054f into home-assistant:dev Nov 7, 2018
@ghost ghost removed the in progress label Nov 7, 2018
@ludeeus ludeeus deleted the sensor.ruter_reuse_session branch November 7, 2018 18:56
@balloob balloob mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants