Add Norwegian Public Transportation sensor (Ruter).

[ludeeus]

Description:

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7379

Example entry for configuration.yaml (if applicable):

sensor:
  platform: ruter
  stopid: 2190400

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

[amelchio]

Looks good, I just have a few proposals for slight cleanups.

[ludeeus]

Thanks @amelchio :)
I think I caught all requests :) have also updated the docs to match the change from stopid to stop_id

[balloob]

@amelchio you can merge if you approve 👍

[MartinHjelmare]

We want all libraries that use aiohttp to take a session argument so that we can reuse the home assistant session throughout the app.

[ludeeus]

I was not aware of that, will change it that and create a new PR later today :)

[amelchio]

Isn't it more like "we would like"? I believe that part of the deal with using third party libraries is that we don't get to dictate their interface.

Still, @ludeeus, please do continue with implementing that :)

[balloob]

@amelchio we don't have to dictate their interface, but very much like if they do take in an optional aiohttp session instead of creating their own if they use aiohttp.

[amelchio]

Yes, and for a library created for Home Assistant that is no biggie. I was more concerned about rejecting a new platform because an existing library does not support passing in the session.

[balloob]

Ah no, we wouldn't do that.

[1v4r]

Very cool to see this implemented in Home Assistant.
Will this be updated to use the Entur-API once the Ruter API is terminated? That would be cool as Entur includes the full national public transport service. Not just Oslo and Akershus.
https://ruter.no/labs/

[Danielhiversen]

Entur is integrated:
#17286

Please, do not used closed pr for discussion.