Add SUPPORT_SEEK for DLNA DMR devices + now (better) providing media_image_url for DLNA DMR devices#18157
Conversation
…age_url for DLNA DMR devices
|
Code-wise this looks pretty straightforward, however, I'm not getting images displayed for my sonoses (works with media_player.sonos though). The |
|
@rytilahti To be certain, does the method/property DlnaDmrDevice.media_image_url return ERR_INVALID_RESPONSE? And did it work before? Can you try, from the environment where you run Home Assistant run this: And start playing media on your Sonos? This starts listen for UPnP events and shows them. Specifically, I'm looking for some DIDL-Lite/escaped XML. |
|
I don't think it used to work, but I suppose the property didn't exist earlier (although it's been some time since I had the platform enabled). The error is coming when trying to access the URL in that property manually with the browser. Here's a one-time unescaped value of So it's returning a relative URI for it. Here's what soco does: https://github.com/SoCo/SoCo/blob/master/soco/music_library.py#L59 . (btw, please document |
|
Fixed in |
|
With additional fix by @rytilahti , to be released later on. |
|
Fixes are in #18377. |
Description:
Add SEEK mode for to DLNA DMR devices and upgrade to
async_upnp_client==0.13.2to better support media_image_urlRelated issue (if applicable): fixes #18040
Pull request in home-assistant.io with documentation (if applicable): not applicable
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: