SMA: Optional import in schema & backoff fix#18099
SMA: Optional import in schema & backoff fix#18099kellerza merged 2 commits intohome-assistant:devfrom
Conversation
homeassistant
added
cla-signed
platform: sensor.sma
small-pr
ghost
added
in progress
and removed
platform: sensor.sma
small-pr
| backoff = 10 | ||
| if not values: | ||
| try: | ||
| backoff = [1, 1, 1, 6, 6, 6, 30, 30][backoff_step] |
There was a problem hiding this comment.
This looks ok. I would probably instead use a start value that is multiplied and cap it with min and max values. The value would represent the time until next try. Eg:
https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/netgear_lte.py#L110
But maybe we need a different approach here? You know the integration best.
There was a problem hiding this comment.
Let’s keep this. I will change to 1,1,1,6,30 and end with the 60
Reasoning
The current implementation ensures multiples of SCAN_INTERVAL, which feels consistent for reporting. Can likely do time based delay, but it will need to take S_I into account.
The library is fairly resilient and that why I have the many 1xS_I to start. If something goes wrong (a) might be network based or (b) not sure about the exact timeout when the user will be available(might have logged in through browser etc)
| """Set up SMA WebConnect sensor.""" | ||
| import pysma | ||
|
|
||
| # Check config again during load - dependancy available |
There was a problem hiding this comment.
Let's try this 'suggested change' feature 😉
| # Check config again during load - dependancy available | |
| # Check config again during load - dependency available |
There was a problem hiding this comment.
Thanks @tjorim ! I fixed this on Friday, but could not push due to issues on github. I pushed my fixes now
There was a problem hiding this comment.
This suggested change feature looks quite cool though!
6 participants
Description:
Checklist:
tox. Your PR cannot be merged unless tests pass