Skip to content

Update SMA sensor#17988

Merged
kellerza merged 3 commits intohome-assistant:devfrom
kellerza:smajmes
Oct 31, 2018
Merged

Update SMA sensor#17988
kellerza merged 3 commits intohome-assistant:devfrom
kellerza:smajmes

Conversation

@kellerza
Copy link
Copy Markdown
Member

Description:

Updated pysma to 0.2.2 and uses the new attr based sensors

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

sensor:
  pysma:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Copy link
Copy Markdown

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@kellerza kellerza changed the title [WIP] Update SMA sensor Update SMA sensor Oct 31, 2018
@kellerza kellerza merged commit 7363378 into home-assistant:dev Oct 31, 2018
@ghost ghost removed the in progress label Oct 31, 2018
@kellerza kellerza deleted the smajmes branch October 31, 2018 19:09

def _check_sensor_schema(conf):
"""Check sensors and attributes are valid."""
import pysma
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requirements are not available when config validation is taking place.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, I asked in the chat, but had no reply there. Will update & move this to the setup routine

@grantclem
Copy link
Copy Markdown

grantclem commented Nov 4, 2018

There appears to be an issue with the SMA component (has been working fine up until now) you can check out the beta channel on Discord for more information. Basically when it is enabled a lot of my sensors are missing. If I disable the component (SMA), all sensors return. Logs are not telling me much sorry.

@kellerza
Copy link
Copy Markdown
Member Author

kellerza commented Nov 4, 2018

It should be fixed in #18099

@JoooostB
Copy link
Copy Markdown

JoooostB commented Nov 5, 2018

It should be fixed in #18099

Updated to the dev container a couple of minutes ago, but still experiencing the same issue as @grantclem

@grantclem
Copy link
Copy Markdown

still no change with 0.82b2

@balloob balloob mentioned this pull request Nov 9, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants