Switch to using Client from twilio.rest rather than the deleted TwiloRestClient#17883
Merged
balloob merged 1 commit intohome-assistant:devfrom Oct 27, 2018
Merged
Conversation
homeassistant
added
cla-signed
integration: twilio
small-pr
ghost
added
the
houndci-bot
reviewed
Oct 27, 2018
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last):
File "/home/linters/.local/bin/flake8", line 7, in
from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Twilio changed the class that needs to be used from
TwilioRestClienttoClient. Source.This broke after the twilio client was upgraded in #17424 and an API change was missed.
Related issue (if applicable): fixes #17871
This one is affecting 0.81 and should be shipped in the next bugfix release. However, I'm not sure how to do that since the component itself was rewritten in #17715 (so the files are not in the same place). This pull request is targeted at dev for release with 0.82.0 and #17885 is targeted at master in case that helps for the hotfix for 0.81.x.
Checklist:
tox. Your PR cannot be merged unless tests pass