Upgrade twilio package to version 6.19.1 (#17395)#17424
Merged
fabaff merged 1 commit intohome-assistant:devfrom Oct 18, 2018
bgianfo:update-twilio
Merged
Upgrade twilio package to version 6.19.1 (#17395)#17424fabaff merged 1 commit intohome-assistant:devfrom bgianfo:update-twilio
fabaff merged 1 commit intohome-assistant:devfrom
bgianfo:update-twilio
Conversation
Contributor
homeassistant
added
cla-needed
integration: twilio
small-pr
ghost
added
the
Member
|
There are issues which needs to be addressed: ************* Module homeassistant.components.twilio
homeassistant/components/twilio.py:54:8: E0611: No name 'Response' in module 'twilio.twiml' (no-name-in-module)
************* Module homeassistant.components.notify.twilio_call
homeassistant/components/notify/twilio_call.py:45:8: E0611: No name 'TwilioRestException' in module 'twilio' (no-name-in-module) |
- Bump twilio requirement to latest 6.19.1 version - The generic response type is gone in the latest versions of the twilio package. It appears we were generating an empty response just to get the empty xml body. TwilML is the new base class all responses inherit from. So I've switched the code over to using and empty TwilML object instead. - The exception type was moved to a different location.
bgianfo
changed the title
Merged
This was referenced Oct 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Bump twilio requirement to latest 6.19.1 version
Fix API breakages.
Related issue (if applicable): fixes #17395