Update pynobo to 1.9.0#170559
Conversation
|
Hey there @echoromeo, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
silamon
left a comment
There was a problem hiding this comment.
This added some types to the pynobo library, and you will also need to adjust the integration code to fix the mypy issues in this pull request.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hmm - prek passed locally before I pushed, but maybe it didn't check the code since I didn't touch it? Fixed now. I'm also preparing a separate PR to leverage the new types in nobo_hub |
|
One of the tests timed out - seems unrelated. |
Proposed change
Update
pynoboto 1.9.0. This is required to get the integration to silver on the quality scale.1.9.0 release notes
Full Changelog: echoromeo/pynobo@v1.8.1...v1.9.0
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: