Skip to content

Update pynobo to 1.9.0#170559

Merged
joostlek merged 5 commits into
home-assistant:devfrom
oyvindwe:nobo_hub-pynobo-1.9.0
May 14, 2026
Merged

Update pynobo to 1.9.0#170559
joostlek merged 5 commits into
home-assistant:devfrom
oyvindwe:nobo_hub-pynobo-1.9.0

Conversation

@oyvindwe
Copy link
Copy Markdown
Contributor

Proposed change

Update pynobo to 1.9.0. This is required to get the integration to silver on the quality scale.

1.9.0 release notes

Full Changelog: echoromeo/pynobo@v1.8.1...v1.9.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings May 14, 2026 07:54
@home-assistant home-assistant Bot added cla-signed dependency Pull requests marked as a dependency upgrade integration: nobo_hub small-pr PRs with less than 30 lines. by-code-owner Quality Scale: bronze labels May 14, 2026
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @echoromeo, mind taking a look at this pull request as it has been labeled with an integration (nobo_hub) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of nobo_hub can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign nobo_hub Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

@silamon silamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This added some types to the pynobo library, and you will also need to adjust the integration code to fix the mypy issues in this pull request.

@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft May 14, 2026 08:42
@oyvindwe
Copy link
Copy Markdown
Contributor Author

This added some types to the pynobo library, and you will also need to adjust the integration code to fix the mypy issues in this pull request.

Hmm - prek passed locally before I pushed, but maybe it didn't check the code since I didn't touch it? Fixed now.

I'm also preparing a separate PR to leverage the new types in nobo_hub

@oyvindwe oyvindwe marked this pull request as ready for review May 14, 2026 10:10
@home-assistant home-assistant Bot requested a review from silamon May 14, 2026 10:10
@oyvindwe
Copy link
Copy Markdown
Contributor Author

One of the tests timed out - seems unrelated.

@joostlek joostlek merged commit 98f5c81 into home-assistant:dev May 14, 2026
48 checks passed
@oyvindwe oyvindwe deleted the nobo_hub-pynobo-1.9.0 branch May 14, 2026 14:04
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed dependency Pull requests marked as a dependency upgrade integration: nobo_hub Quality Scale: bronze small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants