Datetime fixes#37
Merged
Merged
Conversation
- Set default value of dt for get_week_profile_status when actually called - Use timezone from initialization for current datetime - Improved debug logging with datetimes
capelevy
approved these changes
Apr 8, 2024
Collaborator
capelevy
left a comment
capelevy
left a comment
There was a problem hiding this comment.
Looks reasonable.
The dt: datetime.datetime=None can be discussed, but we do not have to live just on the bleeding edge here :)
oyvindwe
added a commit
to oyvindwe/pynobo
that referenced
this pull request
May 3, 2026
- Set default value of dt for get_week_profile_status when actually called - Use timezone from initialization for current datetime - Improved debug logging with datetimes
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor issues I discovered while fixing #35, but did not affect the HA integration:
dtforget_week_profile_status()when actually called (similar issue as Fix get_current_zone_mode for 'now' #30)