Skip to content

data grand lyon: update quality scale#170311

Open
Crocmagnon wants to merge 4 commits into
home-assistant:devfrom
Crocmagnon:devel/Crocmagnon/quality-scale
Open

data grand lyon: update quality scale#170311
Crocmagnon wants to merge 4 commits into
home-assistant:devfrom
Crocmagnon:devel/Crocmagnon/quality-scale

Conversation

@Crocmagnon
Copy link
Copy Markdown
Contributor

Proposed change

Update quality scale for data grand lyon integration.

Gold

Platinum

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Data Grand Lyon integration’s declared Integration Quality Scale level and aligns its quality_scale.yaml rule statuses/comments to reflect the integration’s current feature set.

Changes:

  • Mark docs-examples as done in quality_scale.yaml.
  • Change dynamic-devices and stale-devices from done to exempt with explicit rationale.
  • Bump the integration’s declared quality_scale in manifest.json from silver to platinum.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
homeassistant/components/data_grand_lyon/quality_scale.yaml Updates rule statuses to reflect documentation completion and clarifies exemptions for device lifecycle rules.
homeassistant/components/data_grand_lyon/manifest.json Updates the declared integration quality scale level to platinum.

@Crocmagnon Crocmagnon closed this May 11, 2026
@Crocmagnon Crocmagnon deleted the devel/Crocmagnon/quality-scale branch May 11, 2026 15:09
@Crocmagnon Crocmagnon restored the devel/Crocmagnon/quality-scale branch May 11, 2026 15:11
@joostlek joostlek reopened this May 11, 2026
Copilot AI review requested due to automatic review settings May 13, 2026 18:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants