data grand lyon: update quality scale#170311
Open
Crocmagnon wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Data Grand Lyon integration’s declared Integration Quality Scale level and aligns its quality_scale.yaml rule statuses/comments to reflect the integration’s current feature set.
Changes:
- Mark
docs-examplesas done inquality_scale.yaml. - Change
dynamic-devicesandstale-devicesfromdonetoexemptwith explicit rationale. - Bump the integration’s declared
quality_scaleinmanifest.jsonfromsilvertoplatinum.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/data_grand_lyon/quality_scale.yaml | Updates rule statuses to reflect documentation completion and clarifies exemptions for device lifecycle rules. |
| homeassistant/components/data_grand_lyon/manifest.json | Updates the declared integration quality scale level to platinum. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Update quality scale for data grand lyon integration.
Gold
devices- The integration creates devices: Add Data Grand Lyon integration #167946diagnostics- Implements diagnostics: data grand lyon: implement diagnostics #170184discovery-update-info- Integration uses discovery info to update network information: exemptdiscovery- Devices can be discovered: exemptdocs-data-update- The documentation describes how data is updated: add Data Grand Lyon documentation home-assistant.io#44658docs-examples- The documentation provides automation examples the user can use.: data grand lyon: add refresh blueprint home-assistant.io#45281docs-known-limitations- The documentation describes known limitations of the integration (not to be confused with bugs): add Data Grand Lyon documentation home-assistant.io#44658docs-supported-devices- The documentation describes known supported / unsupported devices: add Data Grand Lyon documentation home-assistant.io#44658docs-supported-functions- The documentation describes the supported functionality, including entities, and platforms: add Data Grand Lyon documentation home-assistant.io#44658docs-troubleshooting- The documentation provides troubleshooting information: add Data Grand Lyon documentation home-assistant.io#44658docs-use-cases- The documentation describes use cases to illustrate how this integration can be used: add Data Grand Lyon documentation home-assistant.io#44658dynamic-devices- Devices added after integration setup: exempt, devices are manually removed and added by the userentity-category- Entities are assigned an appropriate EntityCategory: default is fineentity-device-class- Entities use device classes where possible: Add Data Grand Lyon integration #167946entity-disabled-by-default- Integration disables less popular (or noisy) entities: Add Data Grand Lyon integration #167946entity-translations- Entities have translated names: Add Data Grand Lyon integration #167946exception-translations- Exception messages are translatable: data grand lyon: exception translations #170188icon-translations- Entities implement icon translations: data grand lyon: icon translations #170189reconfiguration-flow- Integrations should have a reconfigure flow: data grand lyon: implement reconfiguration flow #170210repair-issues- Repair issues and repair flows are used when user intervention is needed: exempt, no known case for repair flowstale-devices- Stale devices are removed: exempt, devices are manually removed and added by the userPlatinum
async-dependency- Dependency is async: dependency uses aiohttp: https://codeberg.org/Crocmagnon/data_grand_lyon_ha/src/branch/main/pyproject.tomlinject-websession- The integration dependency supports passing in a websession: https://codeberg.org/Crocmagnon/data_grand_lyon_ha/src/branch/main/src/data_grand_lyon_ha/client.pystrict-typing- Strict typing: Add Data Grand Lyon integration #167946Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: