data grand lyon: exception translations#170188
Merged
erwindouna merged 5 commits intoMay 9, 2026
Merged
Conversation
Crocmagnon
commented
May 9, 2026
| entity-disabled-by-default: done | ||
| entity-translations: todo | ||
| exception-translations: todo | ||
| entity-translations: done |
Contributor
Author
There was a problem hiding this comment.
marked as done because work had already been done in the initial PR: #167946
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes user-facing exceptions in the data_grand_lyon integration translatable by switching raised exceptions to use translation_domain/translation_key and adding the corresponding exceptions translations.
Changes:
- Add translatable exception messages to
strings.jsonfor authentication failures and “all stops failed” update failures. - Update the coordinator to raise
ConfigEntryAuthFailedandUpdateFailedusing translation keys instead of hard-coded English strings. - Mark
entity-translationsandexception-translationsas done in the integration quality scale file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/data_grand_lyon/strings.json | Adds exceptions translation entries used by raised coordinator exceptions. |
| homeassistant/components/data_grand_lyon/coordinator.py | Switches exceptions to translation-backed ConfigEntryAuthFailed / UpdateFailed. |
| homeassistant/components/data_grand_lyon/quality_scale.yaml | Updates quality scale statuses for entity/exception translations to done. |
d0a6f91 to
eb797dc
Compare
erwindouna
approved these changes
May 9, 2026
Member
erwindouna
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @Crocmagnon!
erwindouna
requested changes
May 9, 2026
Member
erwindouna
left a comment
There was a problem hiding this comment.
There's a merg conflict. Can you resolve it?
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Comment on lines
+62
to
65
| entity-translations: done | ||
| exception-translations: done | ||
| icon-translations: done | ||
| reconfiguration-flow: todo |
erwindouna
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Make exceptions translatable in data grand lyon integration
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: