Skip to content

data grand lyon: exception translations#170188

Merged
erwindouna merged 5 commits into
home-assistant:devfrom
Crocmagnon:devel/Crocmagnon/entity-translations
May 9, 2026
Merged

data grand lyon: exception translations#170188
erwindouna merged 5 commits into
home-assistant:devfrom
Crocmagnon:devel/Crocmagnon/entity-translations

Conversation

@Crocmagnon
Copy link
Copy Markdown
Contributor

Proposed change

Make exceptions translatable in data grand lyon integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

entity-disabled-by-default: done
entity-translations: todo
exception-translations: todo
entity-translations: done
Copy link
Copy Markdown
Contributor Author

@Crocmagnon Crocmagnon May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marked as done because work had already been done in the initial PR: #167946

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that you mention it!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes user-facing exceptions in the data_grand_lyon integration translatable by switching raised exceptions to use translation_domain/translation_key and adding the corresponding exceptions translations.

Changes:

  • Add translatable exception messages to strings.json for authentication failures and “all stops failed” update failures.
  • Update the coordinator to raise ConfigEntryAuthFailed and UpdateFailed using translation keys instead of hard-coded English strings.
  • Mark entity-translations and exception-translations as done in the integration quality scale file.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
homeassistant/components/data_grand_lyon/strings.json Adds exceptions translation entries used by raised coordinator exceptions.
homeassistant/components/data_grand_lyon/coordinator.py Switches exceptions to translation-backed ConfigEntryAuthFailed / UpdateFailed.
homeassistant/components/data_grand_lyon/quality_scale.yaml Updates quality scale statuses for entity/exception translations to done.

Copilot AI review requested due to automatic review settings May 9, 2026 11:29
@Crocmagnon Crocmagnon force-pushed the devel/Crocmagnon/entity-translations branch from d0a6f91 to eb797dc Compare May 9, 2026 11:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Copy link
Copy Markdown
Member

@erwindouna erwindouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @Crocmagnon!

Copy link
Copy Markdown
Member

@erwindouna erwindouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a merg conflict. Can you resolve it?

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented May 9, 2026

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft May 9, 2026 12:37
Copilot AI review requested due to automatic review settings May 9, 2026 12:45
@Crocmagnon Crocmagnon marked this pull request as ready for review May 9, 2026 12:46
@home-assistant home-assistant Bot requested a review from erwindouna May 9, 2026 12:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment on lines +62 to 65
entity-translations: done
exception-translations: done
icon-translations: done
reconfiguration-flow: todo
@erwindouna erwindouna merged commit e72346c into home-assistant:dev May 9, 2026
33 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 10, 2026
@Crocmagnon Crocmagnon deleted the devel/Crocmagnon/entity-translations branch May 11, 2026 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants