Skip to content

data grand lyon: exception translations #170188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erwindouna merged 5 commits into from
May 9, 2026
Merged

data grand lyon: exception translations #170188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
81effca
data grand lyon: mark entity-translations as done (no change needed)
Crocmagnon May 9, 2026
eb797dc
data grand lyon: make exceptions translatable
Crocmagnon May 9, 2026
2a0be9a
Merge branch 'dev' into devel/Crocmagnon/entity-translations
Crocmagnon May 9, 2026
d6d0a29
Update quality_scale.yaml
Crocmagnon May 9, 2026
15b923c
Update quality_scale.yaml
Crocmagnon May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions homeassistant/components/data_grand_lyon/coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ async def _async_update_data(self) -> dict[str, list[TclPassage]]:
403,
):
raise ConfigEntryAuthFailed(
"Authentication failed for Data Grand Lyon"
translation_domain=DOMAIN,
translation_key="auth_failed",
) from result
LOGGER.warning(
"Error fetching departures for stop %s: %s",
Expand All @@ -75,5 +76,8 @@ async def _async_update_data(self) -> dict[str, list[TclPassage]]:
stops[subentry.subentry_id] = result

if stop_subentries and not stops:
raise UpdateFailed("Error fetching DataGrandLyon data: all requests failed")
raise UpdateFailed(
translation_domain=DOMAIN,
translation_key="update_failed_all_stops",
)
return stops
4 changes: 2 additions & 2 deletions homeassistant/components/data_grand_lyon/quality_scale.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ rules:
entity-category: done
entity-device-class: done
entity-disabled-by-default: done
entity-translations: todo
exception-translations: todo
entity-translations: done
Copy link
Copy Markdown
Contributor Author

@Crocmagnon Crocmagnon May 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marked as done because work had already been done in the initial PR: #167946

Copy link
Copy Markdown
Member

@erwindouna erwindouna May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that you mention it!

exception-translations: done
icon-translations: done
reconfiguration-flow: todo
Comment on lines +62 to 65
repair-issues:
Expand Down
8 changes: 8 additions & 0 deletions homeassistant/components/data_grand_lyon/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,5 +93,13 @@
}
}
}
},
"exceptions": {
"auth_failed": {
"message": "Authentication failed for Data Grand Lyon."
},
"update_failed_all_stops": {
"message": "Error fetching Data Grand Lyon data: all requests failed."
}
}
}