Skip to content

Add fixture for Tuya camera (knkaf1d0dytgyhix)#169967

Merged
epenet merged 2 commits into
home-assistant:devfrom
mik-laj:tuya-camera-fixture
May 7, 2026
Merged

Add fixture for Tuya camera (knkaf1d0dytgyhix)#169967
epenet merged 2 commits into
home-assistant:devfrom
mik-laj:tuya-camera-fixture

Conversation

@mik-laj
Copy link
Copy Markdown
Contributor

@mik-laj mik-laj commented May 7, 2026

Breaking change

Proposed change

New fixture for my device.

Aliexpress: https://pl.aliexpress.com/item/1005007985789278.html?gatewayAdapt=glo2pol

PR with more entitites: #169966

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings May 7, 2026 01:41
@home-assistant home-assistant Bot added cla-signed code-quality has-tests integration: tuya small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage Top 50 Integration is ranked within the top 50 by usage Quality Scale: No score labels May 7, 2026
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented May 7, 2026

Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tuya can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tuya Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Tuya sp_ device fixture for product knkaf1d0dytgyhix (Security Camera) and updates Tuya platform snapshots so the test suite reflects the entities discovered for this device.

Changes:

  • Added a new Tuya camera fixture (sp_knkaf1d0dytgyhix) to the shared test fixture set.
  • Updated snapshot coverage for newly discovered entities across camera/event/light/select/siren/switch.
  • Updated Tuya device registry snapshot to include the new device.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/components/tuya/fixtures/sp_knkaf1d0dytgyhix.json New fixture describing the Security Camera device and its DP/status data.
tests/components/tuya/snapshots/test_camera.ambr Snapshot updates for the new camera entity.
tests/components/tuya/snapshots/test_event.ambr Snapshot updates for the new doorbell-message event entity.
tests/components/tuya/snapshots/test_init.ambr Device registry snapshot updated for the new device entry.
tests/components/tuya/snapshots/test_light.ambr Snapshot updates for the indicator light entity.
tests/components/tuya/snapshots/test_select.ambr Snapshot updates for select entities (sensitivity/modes).
tests/components/tuya/snapshots/test_siren.ambr Snapshot updates for the siren entity.
tests/components/tuya/snapshots/test_switch.ambr Snapshot updates for multiple new config switches.

"alarm_message": "**REDACTED**",
"ipc_contrast": 50,
"ipc_bright": 50,
"initiative_message": "eyJ2IjoiNS4wIiwiZmlsZXMiOlt7ImRhdGEiOiI1ZWViNWI0NjU4OGFlNjgwYWQwNmYwNTIzZTQxYjU4YmY1YzJlOThmZGM4ZWE0OWI4MWQ3ODFmOWU0ZDg0ZDRkNDVlMmVhNmNjYTM0YTY5YmM4NTJkZWJhYjE5ODNlOWM1ZTRlYzkxY2E3MjYxOGY2MjI4YTgyOWRlZmIxOGIyYmY2OGI4NzU5OWNiOGZjZDU4ZDM1NTJkOTAzNDU5N2E3OTE5MjE0YjQxNDYwZjVmMDM0MjRkYTY2Y2VkMWMzODI2NGExN2Q1ZGVlNDQxMmY1MzZkZWM4YTkxZjdkMjg4YzI1OTEzYWQ0ZWQ5MWU1NTUzODRjYjAyYzQ0YmEzMWFlIiwia2V5SWQiOiJkZWZhdWx0IiwiaXYiOiJlN2ZiMmQxOGU1ODY2YWFlMmNmNjE2N2RjNTM5Y2E0YSJ9XSwiY21kIjoiaXBjX21vdGlvbiIsInR5cGUiOiJpbWFnZSJ9"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes me wonder if it should be redacted in diagnostics for everyone.

@epenet epenet merged commit 4e0472f into home-assistant:dev May 7, 2026
33 checks passed
bluephlame pushed a commit to bluephlame/core that referenced this pull request May 8, 2026
Co-authored-by: mik-laj <12058428+mik-laj@users.noreply.github.com>
@github-actions github-actions Bot locked and limited conversation to collaborators May 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality has-tests integration: tuya Quality Scale: No score small-pr PRs with less than 30 lines. Top 50 Integration is ranked within the top 50 by usage Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants