Add support for Inverter Pool Heat Pump (InverGo)#169606
Conversation
home-assistant
Bot
added
cla-error
integration: tuya
new-feature
Top 100
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @tbouron,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:
45fb3f8ea685608df5ce7e295f88bf375d657f0b- This commit has something that looks like an email address (thobouro@amazon.com). Maybe try linking that to GitHub?.
Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:
-
If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
-
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
(substituting "Author Name" and "
git commit --amend --author="Author Name <email@address.com>"email@address.com" for your actual information) to set the authorship information. - If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
- You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
- You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.
- If you only made a single commit you should be able to run
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! ❤️
|
Hey there @tuya, @zlinoliver, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
tbouron
force-pushed
the
tuya/invertgo-heat-pump
branch
from
45fb3f8 to
553da84
Compare
home-assistant
Bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
There was a problem hiding this comment.
Pull request overview
This PR extends the Tuya integration’s support for device category znrb (“Inverter Pool Heat Pump” / InverGo) by exposing additional datapoints as Home Assistant entities.
Changes:
- Add a
child_lockconfig switch forznrbdevices. - Add several new
znrbsensor entities (compressor strength + multiple temperatures). - Add missing Tuya DPCode constants needed to map the new datapoints.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
homeassistant/components/tuya/switch.py |
Adds a child_lock switch entity description for DeviceCategory.ZNRB. |
homeassistant/components/tuya/sensor.py |
Adds multiple new sensor entity descriptions for DeviceCategory.ZNRB. |
homeassistant/components/tuya/const.py |
Extends DPCode with new Tuya DP identifiers used by the added entities. |
tbouron
force-pushed
the
tuya/invertgo-heat-pump
branch
from
d45e051 to
3e5fa90
Compare
tbouron
force-pushed
the
tuya/invertgo-heat-pump
branch
from
45ddd93 to
98f93c7
Compare
| if ( | ||
| temp_unit is not None | ||
| and description.device_class == SensorDeviceClass.TEMPERATURE | ||
| and description.native_unit_of_measurement is None | ||
| ): | ||
| description = replace( | ||
| description, native_unit_of_measurement=temp_unit | ||
| ) |
There was a problem hiding this comment.
See #170338 - which I think should be merged first.
I think this should then be handled inside _validate_device_class_unit
There was a problem hiding this comment.
Aha, that makes sense. I'll rebase on your PR locally and make that change so it can be ready once yours is merged. Thank you @epenet
| key=DPCode.COMPRESSOR_STRENGTH, | ||
| translation_key="compressor_strength", | ||
| state_class=SensorStateClass.MEASUREMENT, | ||
| native_unit_of_measurement=PERCENTAGE, |
tbouron
force-pushed
the
tuya/invertgo-heat-pump
branch
from
95d569e to
ed0799a
Compare
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
|
I think you'll need to update the snapshots to match the latest changes, and then we should be good |
tbouron
force-pushed
the
tuya/invertgo-heat-pump
branch
from
a70a7ac to
575ebef
Compare
|
Note: for the percentage issue I suggest that you create a quirk via https://github.com/home-assistant-libs/tuya-device-handlers to fix the incorrect unit of measurement |
Proposed change
This adds support for Vitalia SilenFlow Pool Heating Pumps (https://www.my-cfgroup.fr/fr/chauffage/pompe-a-chaleur/pac-vitalia-silent-flow-9kw-vitsil09-1). These are reported by Tuya as following:
znrbgpzittzfnzhduquzInverter Pool Heat PumpUnfortunately this category seems not to be documented in the Tuya dev docs. You can find the config entry JSON that describes the component.
Please note that the category
znrbwhere already add by #118415, but this expands on it. I've left out the followingdpIds because I couldn't correlate them to what they were:temp_topandtemp_bottomType of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: