Add quality scale for airnow integration #169709
+70
−1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| rules: | ||
|
Member
There was a problem hiding this comment. Another sidenote, a lot of the variables defined in
Member
There was a problem hiding this comment. I think we can consider removing that entity/device removal |
||
| # Bronze | ||
| action-setup: | ||
| status: exempt | ||
| comment: Integration does not register custom actions. | ||
| appropriate-polling: | ||
| status: done | ||
| comment: Reports are polled every 30 minutes so newly published hourly AirNow reports are picked up promptly. | ||
| brands: done | ||
| common-modules: done | ||
| config-flow-test-coverage: todo | ||
|
|
||
| config-flow: done | ||
|
Member
There was a problem hiding this comment. Please revert the strings from this PR and set this to todo |
||
| dependency-transparency: done | ||
| docs-actions: | ||
| status: exempt | ||
| comment: Integration does not register custom actions. | ||
| docs-high-level-description: done | ||
| docs-installation-instructions: done | ||
| docs-removal-instructions: done | ||
| entity-event-setup: | ||
| status: exempt | ||
| comment: Integration does not subscribe to events. | ||
| entity-unique-id: done | ||
| has-entity-name: done | ||
| runtime-data: done | ||
| test-before-configure: done | ||
| test-before-setup: done | ||
| unique-config-entry: done | ||
|
|
||
| # Silver | ||
| action-exceptions: todo | ||
|
|
||
| config-entry-unloading: done | ||
| docs-configuration-parameters: todo | ||
| docs-installation-parameters: todo | ||
| entity-unavailable: todo | ||
| integration-owner: todo | ||
|
|
||
| log-when-unavailable: todo | ||
| parallel-updates: done | ||
| reauthentication-flow: todo | ||
| test-coverage: todo | ||
|
Member
There was a problem hiding this comment. Sidenote, we should try and patch the library where we use it, instead of patching internals like
Member
There was a problem hiding this comment. Why do we fake the timezone in the diagnostic test? |
||
| # Gold | ||
| devices: todo | ||
|
Comment on lines
+38
to
+41
|
||
| diagnostics: done | ||
| discovery: todo | ||
| discovery-update-info: todo | ||
| docs-data-update: todo | ||
| docs-examples: todo | ||
| docs-known-limitations: todo | ||
| docs-supported-devices: todo | ||
| docs-supported-functions: todo | ||
| docs-troubleshooting: todo | ||
| docs-use-cases: todo | ||
| dynamic-devices: todo | ||
| entity-category: todo | ||
| entity-device-class: | ||
| status: todo | ||
| comment: The ozone sensor can still use the ozone device class. | ||
| entity-disabled-by-default: todo | ||
| entity-translations: todo | ||
| exception-translations: todo | ||
| icon-translations: todo | ||
| reconfiguration-flow: todo | ||
| stale-devices: todo | ||
| repair-issues: todo | ||
| # Platinum | ||
| async-dependency: done | ||
| inject-websession: done | ||
| strict-typing: todo | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -127,7 +127,6 @@ class Rule: | |
| "aftership", | ||
| "agent_dvr", | ||
| "airly", | ||
| "airq", | ||
| "airthings", | ||
| "airthings_ble", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a sidenote, maybe it'd make sense to migrate it to use subentries, like for example
waqi. But this is optional, just wanted to put it out there