Add Tuya pool heating pumps#118415
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hi @cRemE-fReSh
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Contributor
|
Hey there @tuya, @zlinoliver, @frenck, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This comment was marked as off-topic.
This comment was marked as off-topic.
|
I have also the same pool heat pump. If there is anything I can do, please let me know. :) |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Support for znrb added
Support for znrb added
Support for znrb added
Remove Manufacturer
Remove Manufacturer
Remove Manufacturer
Typo
Typo
Typo
Typo
frenck
reviewed
Jun 22, 2024
frenck
approved these changes
Jun 22, 2024
Member
frenck
left a comment
There was a problem hiding this comment.
Thanks, @cRemE-fReSh 👍
../Frenck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
I would like to add support for Pool Heating Pumps, e.g. Poolsana InverNext (https://www.poolsana.de/pool-full-inverter-waermepumpe-poolsana-inverpower-next-15)
Category "znrb", product id "abb8kaxcphfzkwsg". Unfortunately this category seems not to be documented in the tuya dev docs.
Find below the referring Diagnostic file that discribes the component.
tuya-397980156da2e8092eebaee422fa13ec-Wärmepumpe Pool-bf5e6aa83af148249728aae59317f22c(2).json
Remark: I have left out "work_state" because this seems to be a dead status that never chances independent from the state of the heat pump. Same as "mode" from issue #118265 because this does not exist in mine.
It is an "mimimum" integration that allows to get the current temperature, set the set temperature and switch the entity on and off. Same as getting the three values from the entity.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: